fix: add baseUrl to Octokit initialization in update_claude_comment

[ashwin-ant]

Fixes Bad credentials error on GitHub Enterprise Server by passing
GITHUB_API_URL as baseUrl when initializing Octokit, consistent with
other Octokit instances in the codebase.

Fixes #156
Related to #107

Generated with Claude Code

[claude]

Claude finished @ashwin-ant's task in 2m 38s —— View job

---

PR Review: Fix baseUrl in Octokit initialization

I'll review this PR that fixes GitHub Enterprise Server compatibility by adding baseUrl to Octokit initialization.

Todo List:

• Read and analyze the code change in src/mcp/github-file-ops-server.ts
• Check consistency with other Octokit instances in the codebase
• Provide comprehensive code review feedback
• Complete final review summary

Code Review Analysis

Change Summary:
The PR adds baseUrl: GITHUB_API_URL to the Octokit initialization on line 469 in src/mcp/github-file-ops-server.ts within the update_claude_comment tool.

Consistency Verification:
✅ CONFIRMED - All other Octokit instances in the codebase consistently use baseUrl: GITHUB_API_URL:

• Main factory function in src/github/api/client.ts
• Direct fetch calls throughout the MCP server already use ${GITHUB_API_URL}/repos/...
• All application code receives pre-configured Octokit instances from the centralized factory

Review Feedback

✅ Strengths

1. Targeted Fix: Addresses a specific GitHub Enterprise Server compatibility issue with minimal change
2. Consistency: Brings the MCP server's Octokit initialization in line with established patterns
3. Root Cause: Properly fixes the "Bad credentials" error that occurs when GITHUB_API_URL points to enterprise servers
4. Minimal Risk: Single line change with no side effects on existing functionality

✅ Code Quality

• Import: Correctly uses existing GITHUB_API_URL import from ../github/api/config (line 9)
• Configuration: Leverages the same config constant used throughout the codebase
• Pattern: Follows the established pattern from src/github/api/client.ts:15-18

✅ Architecture & Design

• Centralized Config: Uses the centralized GITHUB_API_URL constant which defaults to "https://api.github.com" if not set
• Backward Compatibility: Change is backward compatible - no impact on github.com usage
• Separation of Concerns: The MCP server creating its own Octokit instance is appropriate since it operates independently

✅ Context Analysis

Looking at the broader context:

• The MCP server (lines 467-470) was the only Octokit instance missing the baseUrl parameter
• All direct fetch calls in the same file already use ${GITHUB_API_URL}/repos/... patterns
• This was an oversight rather than an architectural issue

Recommendation: APPROVE ✅

This is a well-targeted fix that:

• ✅ Solves the specific enterprise server authentication issue
• ✅ Maintains consistency with existing codebase patterns
• ✅ Has minimal risk and no breaking changes
• ✅ Follows established configuration practices

The fix is appropriate, safe, and necessary for GitHub Enterprise Server compatibility.

[ashwin-ant]

@claude not quite right, I think we need to pass the url as an env var to the server

[claude]

Claude finished @ashwin-ant's task in 3m 21s —— View job

---

Summary

Fixed the implementation to properly pass GITHUB_API_URL as an environment variable to the MCP server:

1. Updated install-mcp-server.ts: Added GITHUB_API_URL to the environment variables passed when spawning the GitHub file operations MCP server (line 49).

2. Updated github-file-ops-server.ts:

   • Removed the import of GITHUB_API_URL from the config module
   • Added a local constant that reads GITHUB_API_URL from the process environment (line 42)
   • The existing Octokit initialization already uses this constant as baseUrl

This ensures the MCP server properly uses the custom GitHub API URL for GitHub Enterprise Server instances, fixing the bad credentials error reported in #156.

All tests are passing (201 tests, 0 failures).

[ashwin-ant]

@claude let's get the api url from src/github/api/config.ts when passing it here

[claude]

Claude finished @ashwin-ant's task in 2m 28s —— View job

---

Todo List:

• Read src/mcp/install-mcp-server.ts to understand current implementation
• Read src/github/api/config.ts to see how GITHUB_API_URL is exported
• Import GITHUB_API_URL from config and use it when passing to MCP server
• Run tests to ensure the change doesn't break anything
• Commit and push the change

Summary

Updated src/mcp/install-mcp-server.ts to import and use GITHUB_API_URL from src/github/api/config.ts instead of reading process.env.GITHUB_API_URL directly. This ensures consistency with how the API URL is handled throughout the codebase.

All tests are passing (201 tests, 0 failures).