feat: add max_turns parameter support

[ashwin-ant]

• Add max_turns input to action.yml with proper description
• Pass max_turns parameter through to claude-code-base-action
• Update README with documentation and examples for max_turns usage
• Add comprehensive tests to verify max_turns configuration
• Add yaml dependency for test parsing

Closes #148

[claude]

Claude finished @ashwin-ant's task in 1m 3s —— View job

---

PR Review: Add max_turns parameter support

✅ Overall Assessment: This is a well-implemented feature that adds proper max_turns parameter support to the Claude Code Action. The implementation follows best practices and includes comprehensive documentation and testing.

Todo List:

• Read and analyze action.yml changes
• Review README.md documentation updates
• Examine new test file (max-turns.test.ts)
• Check package.json and bun.lock changes
• Provide comprehensive code review feedback

---

✅ Strengths

action.yml - Excellent Implementation

• Proper Input Definition (action.yml:65-68): Well-structured input parameter with clear description
• Correct Parameter Flow (action.yml:118): Properly passes max_turns: ${{ inputs.max_turns }} to the base action
• Good Positioning: Logically placed before timeout_minutes in the inputs section
• Consistent Defaults: Uses empty string default, consistent with other optional parameters

README.md - Comprehensive Documentation

• Multi-location Coverage: Parameter documented in usage example (README.md:74), inputs table (README.md:83), and dedicated section (README.md:317-333)
• Clear Use Cases: Explains practical applications (cost control, time boundaries, CI/CD predictability)
• Good Examples: Provides concrete usage example with appropriate value (max_turns: "5")
• Proper Context: Places the feature in advanced configuration section where it belongs

test/max-turns.test.ts - Thorough Test Coverage

• Complete Validation: Tests input definition, parameter passing, and positioning
• Robust Parsing: Uses proper YAML parsing with yaml library
• Edge Case Testing: Validates input ordering which could break if inputs are reorganized
• Clear Test Structure: Well-organized describe/test blocks with descriptive names

package.json - Minimal, Necessary Change

• Single Addition: Only adds yaml: ^2.3.4 dependency needed for test parsing
• Version Consistency: Uses caret versioning consistent with other dependencies

---

🔍 Minor Observations

1. Type Safety: The parameter uses string type in action.yml (standard for GitHub Actions), but the base action likely handles string-to-number conversion internally
2. Default Behavior: Empty string default means unlimited turns when not specified - this is appropriate for backward compatibility
3. Documentation Completeness: All relevant sections updated - no missing documentation gaps

---

🎯 Architecture & Design

• Follows Existing Patterns: Implementation mirrors other optional parameters like timeout_minutes
• Clean Parameter Flow: Simple pass-through design keeps the wrapper action thin
• Backward Compatible: Optional parameter doesn't break existing workflows
• Future-Proof: Positioning and structure allow for easy addition of related parameters

---

✅ Security & Best Practices

• No Security Concerns: Parameter is non-sensitive configuration value
• Input Validation: Base action handles parameter validation (appropriate separation of concerns)
• Testing Strategy: Comprehensive tests prevent regression

---

🏆 Recommendation: APPROVE

This PR successfully implements the max_turns parameter with:

• ✅ Correct technical implementation
• ✅ Comprehensive documentation
• ✅ Thorough test coverage
• ✅ No breaking changes
• ✅ Follows established patterns

Ready to merge - this is a high-quality implementation that enhances the action's configurability while maintaining backward compatibility.

[ashwin-ant]

@claude actually remove the test added here and remove the package.json/bun.lock change

[claude]

Claude finished @ashwin-ant's task in 1m 38s —— View job

---

Todo List:

• Remove test/max-turns.test.ts file
• Revert package.json changes (remove yaml dependency)
• Revert bun.lock changes
• Commit changes to PR branch

---

Summary

Successfully removed the test file and reverted package.json/bun.lock changes as requested:

• Deleted: test/max-turns.test.ts
• Reverted: Removed yaml: ^2.3.4 dependency from package.json
• Regenerated: bun.lock without the yaml dependency

The PR now contains only the core feature implementation:

• ✅ action.yml - max_turns parameter definition
• ✅ README.md - documentation for max_turns usage

All changes have been committed to the PR branch.