fix(set due date dialog): set TabLayout background to transparent#19938
Merged
mikehardy merged 1 commit intoankidroid:mainfrom Dec 27, 2025
Merged
fix(set due date dialog): set TabLayout background to transparent#19938mikehardy merged 1 commit intoankidroid:mainfrom
mikehardy merged 1 commit intoankidroid:mainfrom
Conversation
- fixes tab layout color inconsistency in set due date dialog when theme is black/dark - Ref: ankidroid#19936
Member
|
The fix LGTM
|
Member
Author
Done! |
BrayanDSO
approved these changes
Dec 27, 2025
mikehardy
approved these changes
Dec 27, 2025
Member
mikehardy
left a comment
There was a problem hiding this comment.
all of David's requests are handled, great explanation, looks like a good fix, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes tab layout color inconsistency in set due date dialog when theme is black/dark
Fixes
Approach
Sets background color of tab layout to transparent
How Has This Been Tested?
Tested on the following Android Emulators:
Pixel Tablet API 36
Before:

After:

Learning (optional, can help others)
42450f1Why the TabLayout background changed
42450f1, this changed who provides theLayoutInflater.setView(R.layout.dialog_set_due_date), which allowsMaterialAlertDialogto inflate the layout using its dialog theme overlay.DialogSetDueDateBinding.inflate(layoutInflater). This uses a plain inflater without the dialog’s theme overlay.TabLayoutderives its default background color from the currently applied theme/overlay. Because the dialog overlay was no longer applied during inflation, it fell back to the app’s surface color, resulting in the visible theme-colored bar.Checklist
Please, go through these checks before submitting the PR.