Skip to content

Comments

chore: convert SetDueDateDialog to ViewBinding #19483

Merged
mikehardy merged 3 commits intoankidroid:mainfrom
david-allison:vb_SetDueDateDialog
Nov 15, 2025
Merged

chore: convert SetDueDateDialog to ViewBinding #19483
mikehardy merged 3 commits intoankidroid:mainfrom
david-allison:vb_SetDueDateDialog

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Pixel 6 Pro API 33 Emulator - dialog opens
  • Pixel 34 Tablet emulator - dialog opens

Learning

TabItem IDs don't work with ViewBinding: https://redirect.github.com/material-components/material-components-android/issues/1409

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Nov 14, 2025
92 tasks
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the changes.

On a side note, does the keyboard appear for any of those EditTexts in this dialog?

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Nov 15, 2025
@david-allison
Copy link
Member Author

Should do

Screenshot 2025-11-15 at 21 26 04

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy mikehardy added this pull request to the merge queue Nov 15, 2025
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 15, 2025
Merged via the queue into ankidroid:main with commit 42450f1 Nov 15, 2025
15 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 15, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 15, 2025
@david-allison david-allison deleted the vb_SetDueDateDialog branch November 16, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants