Introduce ChangeNoteType Dialog

[Haz3-jolt]

Purpose / Description

Introduces the changeNoteTypeDialog and changeNoteTypeViewModel

Fixes

• Fixes Add: Change Note Types Dialog #14134

How Has This Been Tested?

Pixel 9 Pro (Android 1

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner
  • ❗️ It doesn't like the fixed height of our spinner control - we should add an issue

[github-actions]

Important

Maintainers: This PR contains Strings changes

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

[david-allison]

People have been wanting this for AGES, thanks so much!! 🥳🥳🥳🥳🥳

Looks great, cheers!

SO many users will love this, let me know if you want me to dig in and rebase/force push to get this up to scratch

Crash (resolved)

---

1 card: Basic

• Go to 'Templates'
• Change' Type' to 'Basic & Reversed'

Crash

2025-06-22 21:38:42.737 24328-24328 ChangeNote...ateSpinner com.ichi2.anki.debug                 D  Updating card mapping: old template 0 -> new template 0
2025-06-22 21:38:42.738 24328-24328 ChangeNote...ateSpinner com.ichi2.anki.debug                 D  Updating card mapping: old template 1 -> new template null
2025-06-22 21:38:42.738 24328-24328 ChangeNoteTypeViewModel com.ichi2.anki.debug                 W  Attempted to update card mapping before initialization
2025-06-22 21:38:42.757 24328-24328 ThrowableFilterService  com.ichi2.anki.debug                 V  exceptionIsUnwanted - examining IndexOutOfBoundsException
2025-06-22 21:38:42.757 24328-24328 ThrowableFilterService  com.ichi2.anki.debug                 V  exceptionIsUnwanted - exception was wanted
2025-06-22 21:38:42.757 24328-24328 UsageAnalytics          com.ichi2.anki.debug                 D  sendAnalyticsException() description/fatal: java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1/true
2025-06-22 21:38:42.763 24328-24328 ACRA                    com.ichi2.anki.debug                 E  ACRA caught a IndexOutOfBoundsException for com.ichi2.anki.debug
                                                                                                    java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
                                                                                                    	at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
                                                                                                    	at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
                                                                                                    	at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
                                                                                                    	at java.util.Objects.checkIndex(Objects.java:385)
                                                                                                    	at java.util.ArrayList.get(ArrayList.java:434)
                                                                                                    	at com.ichi2.anki.dialogs.ChangeNoteTypeViewModel.getDiscardedCards(ChangeNoteTypeViewModel.kt:261)
                                                                                                    	at com.ichi2.anki.dialogs.ChangeNoteTypeViewModel$getDiscardedCards$1.invokeSuspend(Unknown Source:20)
                                                                                                    	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                                    	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:995)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:103)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:248)
                                                                                                    	at android.os.Looper.loop(Looper.java:338)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:9067)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:932)
                                                                                                    	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@6e28089, Dispatchers.Main.immediate]

On me

[Haz3-jolt]

Nothing much, just a commit message fix

I'm no longer able to see any of the review comments here, but David has reviewed it quite recently and approved after a fair bit of back and forth, so will assume these are stale

[mikehardy]

incredible piece of functionality, the test implementation looks really thorough and I don't have any quibbles on the implementation as I read it except a desire to make the "TODO" for list separator a concrete thing by doing it in compat

the other two tiny comments are adminsitrative (attribution) or trivial (spacing)

consider this an approve if those are handled, I'd love to get this merged

[mikehardy]

strings are in sync and ready to go, I was hoping to merge it for what it's worth :-), let's go!

[david-allison]

GREAT JOB!!!!!!!

[david-allison]

• Updated strings from Crowdin 2026/01/19 09:48 #20156

consider this an approve if those are handled

[github-actions]

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings