Update to @angular 2.0.0-rc0 packages and latest CLI #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| }); | ||
| it('should emit a change event when the `checked` value changes', () => { | ||
| // TODO(jelbourn): this *should* work with fakeAsync, but there seems to be a bug. | ||
| // As a short-term soltution, use a promise (which jasmine knows how to understand). |
|
Left a few nitpicky comments about consolidating imports, typos, etc. But looks good to me otherwise. |
| }, | ||
| '@angular/core': { |
There was a problem hiding this comment.
Nitpick: we could probably build this object with a function and an array of bundle names to save the copy-pasting. But probably outside the scope of this PR
|
@hansl Going to wait for new CLI version on top of new packages before submitting this. |
|
Also going to |
jelbourn
changed the title
This was referenced May 4, 2016
Merged
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular#9648
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress PR to run CI tests w/ new world.
Also I rewrote all of the checkbox tests to be dramatically cleaner.