Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): export icon registry as part of icon #366

Merged
merged 1 commit into from
May 4, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Apr 27, 2016

Currently, if you want to use md-icon, you have to import MdIcon and MdIconRegistry from separate files. This PR consolidates the import, so you can do:

import {MdIcon, MdIconRegistry} from '@angular2-material/icon'

instead of:

import {MdIcon} from '@angular2-material/icon'
import {MdIconRegistry} from '@angular2-material/icon/icon-registry'

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 27, 2016
@kara kara added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Apr 27, 2016
@kara kara added the blocked This issue is blocked by some external factor, such as a prerequisite PR label May 1, 2016
@jelbourn
Copy link
Member

jelbourn commented May 4, 2016

Now needs rebasing on my mega change #384

@kara kara removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label May 4, 2016
@jelbourn
Copy link
Member

jelbourn commented May 4, 2016

LGTM

@jelbourn jelbourn merged commit 5eab2b3 into angular:master May 4, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants