build: show deletion target in docs #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Surfaces the @deletion-target JSDoc information into the Dgeni HTML output. Currently it will add a title to the deprecation marker. Closes angular#9641
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 30, 2018
| @@ -19,7 +21,9 @@ | |||
| </div> | |||
| {%- endif -%} | |||
| {%- if property.isDeprecated -%} | |||
| <div class="docs-api-deprecated-marker">Deprecated</div> | |||
| <div class="docs-api-deprecated-marker" {$ macros.deprecationTitle(property) $}> | |||
There was a problem hiding this comment.
It would also be cool to add a dotted underline to the deprecation marker to indicate that there's a hover effect. We could do this in a follow-up PR on the docs site w/ something like
.docs-api-deprecated-marker[title] {
border-bottom: 1px dotted gray;
}
jelbourn
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material.angular.io
that referenced
this pull request
Feb 6, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
devversion
added a commit
to devversion/material.angular.io
that referenced
this pull request
Feb 6, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
jelbourn
pushed a commit
to angular/material.angular.io
that referenced
this pull request
Feb 9, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9641