Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Add specific RTV opt-in to experiments.html #26434

Merged
merged 10 commits into from
Jan 23, 2020
Merged

🏗 Add specific RTV opt-in to experiments.html #26434

merged 10 commits into from
Jan 23, 2020

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Jan 21, 2020 •
edited
Loading

Fixes #25205

image

image

Tag-along change:

  • Renamed dev/rc to experimental/beta (UI-facing change only, no backend change here)

rcebulko
rcebulko reviewed Jan 21, 2020
View reviewed changes
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
rsimha
rsimha reviewed Jan 21, 2020
View reviewed changes
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
rsimha
rsimha reviewed Jan 21, 2020
View reviewed changes
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
rsimha
rsimha reviewed Jan 22, 2020
View reviewed changes
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
rcebulko
rcebulko reviewed Jan 23, 2020
View reviewed changes
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.html Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
@danielrozenberg @rcebulko
Update tools/experiments/experiments.html
b17b530 
Co-Authored-By: Ryan Cebulko <ryan@cebulko.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ampproject ampproject deleted a comment from googlebot Jan 23, 2020
@ampproject ampproject deleted a comment from googlebot Jan 23, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

rsimha
rsimha approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enduring this review :)

@danielrozenberg danielrozenberg merged commit 7f4d134 into ampproject:master Jan 23, 2020
@danielrozenberg danielrozenberg deleted the opt-in-experiments branch January 23, 2020 19:11
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 27, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
eb0cd44 
* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko left review comments

@estherkim estherkim estherkim left review comments

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I2I: Opt-in to Specific AMP RTV
5 participants
@danielrozenberg @googlebot @rcebulko @rsimha @estherkim