✨ Performance Measurement Chrome Extension #26333
Conversation
wassgha
changed the title
|
Can we limit the items shown to FID, LCP, and CLS? |
There was a problem hiding this comment.
Can you add an OWNERS file?
@rsimha – Do you think wg-performance or wg-infrastructure should maintain this going forward?
Good question, @kristoferbaxter. I'm assuming that:
Based on this, I think it should be owned and maintained by @ampproject/wg-performance. If in future, it becomes feasible for this tool to be used as part of releases / CI, someone from @ampproject/wg-infra can certainly help with integrating this into our current workflow. WDYT? |
|
@rsimha – I agree. Makes sense to me! |
| * limitations under the License. | ||
| */ | ||
|
|
||
| function renderMeasurement(container, label, count) { |
There was a problem hiding this comment.
Nit: innerHTML, since we control the label and count?
There was a problem hiding this comment.
I return the countSpan here so if we use innerHTML there will be an extra querySelector so pretty much the same amount of work... Leaving it for now.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| * limitations under the License. | ||
| */ | ||
|
|
||
| function renderMeasurement(container, label, count) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* master: (62 commits) 📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491) Revert 'Move mutator implementations out to a standalone service' (ampproject#26479) Fix syntax error (ampproject#26481) Add pespective back. (ampproject#26486) More user friendly errors in layout.js (ampproject#26448) ✨ Start logging AMP URL on SwG Pages (ampproject#26480) Fix border around desktop amp-story-pages. (ampproject#26449) Fix Story tests. (ampproject#26464) ✨ Performance Measurement Chrome Extension (ampproject#26333) amp-consent restrict iframe fullScreen if no focus (ampproject#26461) Add performance benchmark task (ampproject#26026) ♻️ amp-script: emit warning if zero height and width. (ampproject#26444) ✨ Launch minimal-wrapper native CEv1 (ampproject#26360) ♻️ Lint: include externs (round 2) (ampproject#26446) amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400) amp-consent remove cmp iframe focus (ampproject#26437) Disable macro-after-long-task in inabox. (ampproject#26459) Launch layoutbox-invalidate-on-scroll (ampproject#26430) Add amp-ad support for ByPlay (ampproject#25663) 🏗 Add specific RTV opt-in to experiments.html (ampproject#26434) ...
Implements a chrome extension that helps with performance measurement. Currently supports the following metrics:
Overlays the measurements on the page as follows:
