Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Lint: include externs (round 2) #26446

Merged
merged 2 commits into from
Jan 23, 2020
Merged

♻️ Lint: include externs (round 2) #26446

merged 2 commits into from
Jan 23, 2020

Conversation

samouri
Copy link
Member

@samouri samouri commented Jan 22, 2020 •
edited
Loading

Reverts the revert (#26445)

  • also fixes the failing tests by running prettier on the newly added preact extern.

@samouri samouri removed the request for review from jridgewell January 22, 2020 22:59
@samouri samouri changed the title Revert "Revert "♻️ Lint: include externs"" ♻️ Lint: include externs (round 2) Jan 22, 2020
rsimha
rsimha approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for jumping through all the hoops twice!

@samouri samouri self-assigned this Jan 22, 2020
@samouri samouri merged commit 9faa367 into master Jan 23, 2020
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 27, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
eb0cd44 
* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...
@samouri samouri mentioned this pull request Feb 3, 2020
Closed
@rsimha rsimha deleted the revert-26445-revert-26228-prettify-externs branch February 13, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@rsimha rsimha rsimha approved these changes

Assignees

@samouri samouri

Labels
cla: yes PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samouri @jridgewell @rsimha @googlebot @ampprojectbot