🏗♻️ Refactor / clean up the watch
logic used for extensions
#22659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
buildExperiments()
frombuild-system/tasks/helpers.js
tobuild-system/tasks/dist.js
(should've been done in 🏗♻️ Splitgulpfile.js
into separate files #22109)watch
logic frombuildExperiments
and cleans up unusedgulp
task (copy-pasted in Experiments.html page for our CDN #923)watch
logic frombuildLoginDoneVersion
and cleans up unusedgulp
task (copy-pasted in Login dialog done HTML page #1330)watch
logic for extensions by using a separate watcher to rebuild an extension when any file in its directory is modified (see No longer recursively install watchers on extensions. #47, Consolidate gulp watch and gulp build #12900, Add missing option to buildExtensions() in gulp watch / gulp build #12911, and 🏗♻️ Refactor and speed up unminified builds #22635)bundleOnlyIfListedInFiles
option used to selectively build extensions (added in RFC: Add --files to allow running specific test files. #3091) now that we have--extensions
and--extensions_from
(added in Add --extensions flag to only build listed extensions #13203, Support--extensions=minimal_set
& bug fix #13249, and 🏗🚀Allow building extensions from an example document #17129)Follow up to #47, #923, #1330, #3091, #12900, #12911, #13203, #13249, #17129, #22109, and #22635