Login dialog done HTML page #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
access7
branch
2 times, most recently
from
ad1b2de
to
1619517
Compare
| */ | ||
| buildStyles_() { | ||
| const nav = this.win.navigator; | ||
| const lang = nav.language || nav.userLanguage || 'en-US'; |
There was a problem hiding this comment.
Neat. Probably makes sense to prefer a URL arg like "?hl=de", so pubs can chose to tell us the lang of the transaction.
There was a problem hiding this comment.
Ok. I'll add the attribute and default to navigator.language when not specified.
|
LGTM |
|
I added "hl" query parameter and also added additional fallback when no nodes match the selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.