Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel watch if an edit causes a compilation error #13312

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Don't cancel watch if an edit causes a compilation error #13312

merged 1 commit into from
Feb 6, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 6, 2018

When gulp watch is running and an edit causes a compilation error, we currently cancel the watch. We should cancel on error during gulp build and the first build of gulp | gulp watch, but not when an edit causes a recompilation. See #13255 (comment)

Follow up to #13255
Fixes #1213

@rsimha rsimha self-assigned this Feb 6, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Feb 6, 2018

/to @calebcordry

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for getting to this so quickly!

@rsimha rsimha merged commit 9125cfb into ampproject:master Feb 6, 2018
@rsimha rsimha deleted the 2018-02-06-KillOnWatch branch February 6, 2018 23:05
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
@calebcordry
Copy link
Member

@rsimha It seems like this is happening again. Any idea what changed?

@rsimha
Copy link
Contributor Author

rsimha commented Jun 18, 2019

@calebcordry Pretty sure I caused this regression in #22659, particularly this line >_<

Looking for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a non-existing import should fail compilation
4 participants