Importing a non-existing import should fail compilation

[cramforce]

Or at least a separate check.

I assume this is not failing with babel because of per-file compilation, but possibly we can add an extra check.

CC @erwinmombay

[erwinmombay]

weird, i think this would currently fail. will double check.

[adelinamart]

Is this still relevant?

[adelinamart]

@erwinmombay @mrjoro to provide updates here. Thanks

[ampprojectbot]

This issue hasn't been updated in awhile. @erwinmombay Do you have any updates?

[rsimha]

I just tested this with:

const foo = require('foo');
import {bar} from './bar';

It turns out that we print a Cannot find module error, and then proceed with the build. @cramforce shall we make this a fatal error that stops the build?

[cramforce]

Definitely :)

…

On Fri, Feb 2, 2018 at 10:15 AM, Raghu Simha ***@***.***> wrote: I just tested this with: const foo = require('foo'); import {bar} from './bar'; It turns out that we print a Cannot find module error, and then proceed with the build. @cramforce <https://github.com/cramforce> shall we make this a fatal error that stops the build? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFeTwhHdweimuC1SAdzahP3XJwCWKNgks5tQ0TOgaJpZM4G5hss> .

[rsimha]

This is now fixed. Here's what you will see.

Syntax error:

SyntaxError: amphtml/src/foo.js: Unexpected token (20:6)
  18 | 
  19 | if (foo) {
> 20 |   bar(;
     |       ^
  21 | }
  22 | 

Other errors, like bad imports:

Error: Cannot find module './bar' from 'amphtml/src/foo'

[rsimha]

Reopening because we shouldn't cancel watch when an edit causes a compilation error.