-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing a non-existing import should fail compilation #1213
Comments
weird, i think this would currently fail. will double check. |
Is this still relevant? |
@erwinmombay @mrjoro to provide updates here. Thanks |
This issue hasn't been updated in awhile. @erwinmombay Do you have any updates? |
I just tested this with:
It turns out that we print a |
Definitely :)
…On Fri, Feb 2, 2018 at 10:15 AM, Raghu Simha ***@***.***> wrote:
I just tested this with:
const foo = require('foo');
import {bar} from './bar';
It turns out that we print a Cannot find module error, and then proceed
with the build. @cramforce <https://github.com/cramforce> shall we make
this a fatal error that stops the build?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1213 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFeTwhHdweimuC1SAdzahP3XJwCWKNgks5tQ0TOgaJpZM4G5hss>
.
|
This is now fixed. Here's what you will see. Syntax error:
Other errors, like bad imports:
|
Reopening because we shouldn't cancel |
Or at least a separate check.
I assume this is not failing with babel because of per-file compilation, but possibly we can add an extra check.
CC @erwinmombay
The text was updated successfully, but these errors were encountered: