Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use latest Chrome, Firefox and Chrome Dev #19392

Merged
merged 25 commits into from
Nov 29, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update integration tests
  • Loading branch information
estherkim committed Nov 20, 2018
commit 9d364f004fe1205945a68b46b987e933d7cfaa7e
2 changes: 1 addition & 1 deletion build-system/tasks/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ module.exports = {
}, SAUCE_TIMEOUT_CONFIG),
SL_iOS_12: Object.assign({
base: 'SauceLabs',
appiumVersion: '1.8.1',
appiumVersion: '1.9.1',
deviceName: 'iPhone X Simulator',
browserName: 'Safari',
platformName: 'iOS',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe.configure().run('amp-fx-collection', function() {
expect(getComputedLeft(win)).to.be.above(initialLeft);
});
});
});
}).skip(); //TODO: fails in Firefox 63.0.0

// Can't test a default `fly-in-right` animation as the
// `data-fly-in-distance` and `data-duration` parameters differ/device.
Expand Down Expand Up @@ -105,7 +105,7 @@ describe.configure().run('amp-fx-collection', function() {
expect(getComputedLeft(win)).to.be.below(initialLeft);
});
});
});
}); //TODO: fails in Firefox 63.0.0
estherkim marked this conversation as resolved.
Show resolved Hide resolved

// Can't test a default `fly-in-bottom` animation as the
// `data-fly-in-distance` and `data-duration` parameters differ/device.
Expand Down