Update integration tests to use latest Chrome, Firefox and Chrome Dev #19392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
reviewed
Nov 20, 2018
danielrozenberg
requested changes
Nov 26, 2018
danielrozenberg
approved these changes
Nov 27, 2018
rsimha
reviewed
Nov 27, 2018
extensions/amp-fx-collection/0.1/test/integration/test-amp-fx-fly-in.js
Outdated
Show resolved
Hide resolved
extensions/amp-fx-collection/0.1/test/integration/test-amp-fx-fly-in.js
Outdated
Show resolved
Hide resolved
|
@estherkim Nice work so far! Let me know when this PR is ready for a final review, or if you need help in figuring out what to do with the failures. |
rsimha
reviewed
Nov 29, 2018
rsimha
suggested changes
Nov 29, 2018
ampprojectbot
requested review from
aghassemi,
cvializ,
danielrozenberg,
nainar and
rsimha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18784
Updates Sauce Labs platforms to use latest Chrome and Firefox versions automatically.