Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use latest Chrome, Firefox and Chrome Dev #19392

Merged
merged 25 commits into from
Nov 29, 2018
Merged

Update integration tests to use latest Chrome, Firefox and Chrome Dev #19392

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b6e57cc
Update SauceLabs platforms to latest
estherkim Nov 19, 2018
64c2174
Merge branch 'master' into esth-chromecanary
estherkim Nov 19, 2018
328b25f
Update browser name
estherkim Nov 19, 2018
9d364f0
Update integration tests
estherkim Nov 20, 2018
384bb83
Skip tests
estherkim Nov 20, 2018
8a887b7
Batch integration tests
estherkim Nov 21, 2018
29ca928
Batch saucelabs tests
estherkim Nov 21, 2018
f3f5c1b
Move when test server is killed
estherkim Nov 21, 2018
41dc25c
Add logging
estherkim Nov 21, 2018
0e1826b
Comment out setTimeout
estherkim Nov 21, 2018
d8ff1df
Remove IE 11 from --saucelabs list
estherkim Nov 21, 2018
a272b4f
Remove whitespace
estherkim Nov 21, 2018
40bac8a
Address runtime-test.js PR comments
estherkim Nov 27, 2018
f9bc86a
Merge branch 'master' into esth-chromecanary
estherkim Nov 27, 2018
544e60a
Copy config instead of pointing to it
estherkim Nov 27, 2018
9cfdab1
Remove karma concurrency limit
estherkim Nov 27, 2018
0f649ea
Combine batch exit codes
estherkim Nov 28, 2018
9969f55
Oops whitespace
estherkim Nov 28, 2018
daba3a6
Kill process at end of saucelabs tests if errors
estherkim Nov 28, 2018
5676797
Set process exit code for timedExecOrDie
estherkim Nov 28, 2018
01fc7d6
Update exit code
estherkim Nov 28, 2018
43cebef
Update browser list
estherkim Nov 28, 2018
2e36c40
Uncomment setTimeout
estherkim Nov 29, 2018
52b7b31
PR comments
estherkim Nov 29, 2018
b9d2f36
PR comments
estherkim Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add logging
  • Loading branch information
@estherkim
estherkim committed Nov 21, 2018
commit 41dc25c6c3dee6bc0e324bf1250a34bbaa2c9e23
12 changes: 7 additions & 5 deletions build-system/tasks/runtime-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const preTestTasks = argv.nobuild ? [] : (
(argv.unit || argv.a4a || argv['local-changes']) ? ['css'] : ['build']);
const extensionsCssMapPath = 'EXTENSIONS_CSS_MAP';

let browsers = [];
let saucelabsBrowsers = [];
/**
* Read in and process the configuration settings for karma
* @return {!Object} Karma configuration
Expand Down Expand Up @@ -71,7 +71,7 @@ function getConfig() {
throw new Error('Missing SAUCE_ACCESS_KEY Env variable');
}

browsers = argv.saucelabs ?
saucelabsBrowsers = argv.saucelabs ?
// With --saucelabs, integration tests are run on this set of browsers.
[
'SL_Chrome',
Expand All @@ -92,7 +92,7 @@ function getConfig() {

return Object.assign({}, karmaDefault, {
reporters: ['super-dots', 'saucelabs', 'karmaSimpleReporter'],
browsers: [], // Browser list is set during batch process
browsers: saucelabsBrowsers,
});
}
return karmaDefault;
Expand Down Expand Up @@ -399,6 +399,7 @@ async function runTests() {
// Run the tests.
mocha.run(function(failures) {
if (failures) {
log(green('There are failures. Now exiting'));
process.exit(1);
}
resolver();
Expand Down Expand Up @@ -553,11 +554,11 @@ async function runTests() {
while (left < right) {
log(green('Beginning batch number ' + batch));
const configBatch = c;
estherkim marked this conversation as resolved.
Show resolved Hide resolved
configBatch.browsers = browsers.slice(left, right);
configBatch.browsers = saucelabsBrowsers.slice(left, right);
await createKarmaServer(configBatch);
left = batch * batchSize;
batch++;
right = Math.min(batch * batchSize, browsers.length);
right = Math.min(batch * batchSize, saucelabsBrowsers.length);
}
estherkim marked this conversation as resolved.
Show resolved Hide resolved
} else {
await createKarmaServer(c);
Expand Down Expand Up @@ -619,6 +620,7 @@ async function runTests() {
// TODO(rsimha, 14814): Remove after Karma / Sauce ticket is resolved.
if (process.env.TRAVIS) {
setTimeout(() => {
log(green('Process timed out'));
estherkim marked this conversation as resolved.
Show resolved Hide resolved
process.exit(exitCode);
}, 5000);
} else {
Expand Down