[ISSUE #8622] Properties has transformed NacosClientProperties #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Properties - add NacosClientPropertiesLookup for log4j2 - add NacosClientPropertyAction for logback - add a new constructor method to adapt NacosClientProperties for NacosNamingMaintainService - add a new constructor method to adapt NacosClientProperties for NacosNamingService - add a new constructor method to adapt NacosClientProperties for NacosConfigService
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #9356 +/- ##
=============================================
- Coverage 44.07% 43.95% -0.12%
- Complexity 4871 4885 +14
=============================================
Files 914 917 +3
Lines 33155 33228 +73
Branches 3843 3847 +4
=============================================
- Hits 14613 14607 -6
- Misses 17119 17195 +76
- Partials 1423 1426 +3
Continue to review full report at Codecov.
|
KomachiSion
requested changes
Oct 26, 2022
| ServiceLoader<IConfigFilter> configFilters = ServiceLoader.load(IConfigFilter.class); | ||
| for (IConfigFilter configFilter : configFilters) { | ||
| configFilter.init(properties); | ||
| configFilter.init(compatibleProperties); |
There was a problem hiding this comment.
能否转化为Properties？ ConfigFilter是一个插件接口，最好不要改入参数
There was a problem hiding this comment.
这个我转成一个兼容 Properties 的 wrapper. client/src/main/java/com/alibaba/nacos/client/env/SearchablePropertiesWrapper.java
onewe
added a commit
to onewe/nacos
that referenced
this pull request
Nov 2, 2022
- Replace system.getProperties and system.getEnv with NacosClientProperties - remove address server controller IT relate alibaba#9356
5 tasks
onewe
added a commit
to onewe/nacos
that referenced
this pull request
Nov 2, 2022
- Replace system.getProperties and system.getEnv with NacosClientProperties - log4j and logback support reading properties from NacosClientProperties relate alibaba#9356
5 tasks
onewe
added a commit
to onewe/nacos
that referenced
this pull request
Nov 2, 2022
- Replace system.getProperties and system.getEnv with NacosClientProperties relate alibaba#9356
5 tasks
onewe
added a commit
to onewe/nacos
that referenced
this pull request
Nov 3, 2022
- Replace system.getProperties and system.getEnv with NacosClientProperties relate alibaba#9356
5 tasks
KomachiSion
pushed a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate: #8622
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.