Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8622] sub pr of 9356 - logging module #9450

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Nov 2, 2022

  • Replace system.getProperties and system.getEnv with NacosClientProperties
  • log4j and logback support reading properties from NacosClientProperties

relate #9356

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

- Replace system.getProperties and system.getEnv with  NacosClientProperties
- log4j and logback support reading properties from NacosClientProperties

relate alibaba#9356
@codecov-commenter
Copy link

Codecov Report

Merging #9450 (4502231) into develop (0a80276) will increase coverage by 0.04%.
The diff coverage is 36.36%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9450      +/-   ##
=============================================
+ Coverage      47.57%   47.61%   +0.04%     
- Complexity      4561     4568       +7     
=============================================
  Files            851      853       +2     
  Lines          28298    28315      +17     
  Branches        3193     3194       +1     
=============================================
+ Hits           13463    13483      +20     
+ Misses         13600    13599       -1     
+ Partials        1235     1233       -2     
Impacted Files Coverage Δ
...ent/logging/logback/NacosClientPropertyAction.java 0.00% <0.00%> (ø)
...client/logging/logback/NacosJoranConfigurator.java 0.00% <0.00%> (ø)
...aba/nacos/client/logging/AbstractNacosLogging.java 57.14% <100.00%> (ø)
...acos/client/logging/log4j2/Log4J2NacosLogging.java 79.31% <100.00%> (+0.73%) ⬆️
...nt/logging/log4j2/NacosClientPropertiesLookup.java 100.00% <100.00%> (ø)
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 75.00% <0.00%> (-1.25%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 50.96% <0.00%> (+0.19%) ⬆️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.77% <0.00%> (+1.27%) ⬆️
...m/alibaba/nacos/core/remote/ConnectionManager.java 45.85% <0.00%> (+1.47%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a80276...4502231. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add sone unit test?

@KomachiSion KomachiSion merged commit 46e6318 into alibaba:develop Nov 4, 2022
@onewe onewe deleted the issues/9356-2 branch November 4, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants