Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8622] sub pr of 9356 - auth module #9447

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Nov 2, 2022

  • Replace system.getProperties and system.getEnv with NacosClientProperties
  • remove address server controller IT

relate #9356 for #8622

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

- Replace system.getProperties and system.getEnv with  NacosClientProperties
- remove address server controller IT

relate alibaba#9356
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #9447 (7fce0cc) into develop (0a80276) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9447      +/-   ##
=============================================
+ Coverage      47.57%   47.67%   +0.09%     
- Complexity      4561     4563       +2     
=============================================
  Files            851      851              
  Lines          28298    28298              
  Branches        3193     3193              
=============================================
+ Hits           13463    13491      +28     
+ Misses         13600    13575      -25     
+ Partials        1235     1232       -3     
Impacted Files Coverage Δ
...os/client/auth/ram/identify/CredentialWatcher.java 40.00% <100.00%> (ø)
...baba/nacos/client/auth/ram/identify/StsConfig.java 66.66% <100.00%> (ø)
...ess/config/AddressServerSecurityConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/com/alibaba/nacos/address/AddressServer.java 0.00% <0.00%> (-33.34%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
...cos/core/cluster/remote/ClusterRpcClientProxy.java 72.85% <0.00%> (-1.43%) ⬇️
...ess/controller/AddressServerClusterController.java 94.93% <0.00%> (-1.27%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.77% <0.00%> (+1.27%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.40% <0.00%> (+4.63%) ⬆️
...alibaba/nacos/client/env/SearchableProperties.java 88.76% <0.00%> (+11.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a80276...7fce0cc. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.2.0 milestone Nov 3, 2022
@KomachiSion KomachiSion merged commit 645cd4a into alibaba:develop Nov 3, 2022
@onewe onewe deleted the issues/9356-1 branch November 3, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants