Skip to content

Conversation

@algolucky
Copy link
Contributor

@algolucky algolucky commented Nov 1, 2022

Summary

merges in feature/alphanet to master to get the latest changes to the genesis and recipe

cce and others added 30 commits May 26, 2022 12:53
Adjust the DNS Bootstrap Id for Alphanet
alphanet: define vAlpha2 consensus parameters
DevOps: Updated alphanet algonet recipe genesis files to use alpha2 protocol.
@algolucky algolucky requested review from a team and cce November 1, 2022 17:10
@algolucky algolucky self-assigned this Nov 1, 2022
@algolucky algolucky marked this pull request as ready for review November 1, 2022 17:11
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4726 (1e97e3d) into master (36fc7f9) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
- Coverage   54.46%   54.35%   -0.12%     
==========================================
  Files         407      407              
  Lines       52389    52389              
==========================================
- Hits        28536    28476      -60     
- Misses      21477    21531      +54     
- Partials     2376     2382       +6     
Impacted Files Coverage Δ
network/phonebook.go 83.49% <0.00%> (-5.83%) ⬇️
ledger/voters.go 68.65% <0.00%> (-4.48%) ⬇️
ledger/tracker.go 75.74% <0.00%> (-3.83%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/catchpointtracker.go 61.84% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 65.52% <0.00%> (-1.02%) ⬇️
catchup/service.go 68.14% <0.00%> (-0.75%) ⬇️
ledger/acctonline.go 78.12% <0.00%> (-0.53%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also opened #4729 to enable boxes on alphanet

@algojohnlee algojohnlee merged commit e387553 into master Nov 2, 2022
@algojohnlee algojohnlee deleted the feature/alphanet branch November 2, 2022 14:17
@algojohnlee algojohnlee restored the feature/alphanet branch November 2, 2022 14:17
@algolucky algolucky deleted the feature/alphanet branch November 2, 2022 14:19
@algojohnlee algojohnlee restored the feature/alphanet branch November 2, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants