Fixing rpm package name for alphanet #4244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/alphanet #4244 +/- ##
====================================================
+ Coverage 54.56% 54.58% +0.02%
====================================================
Files 391 391
Lines 48798 48798
====================================================
+ Hits 26626 26638 +12
+ Misses 19947 19937 -10
+ Partials 2225 2223 -2
Continue to review full report at Codecov.
|
egieseke
approved these changes
Jul 8, 2022
algolucky
approved these changes
Jul 8, 2022
Contributor
|
should this also be on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently alphanet rpm packages are missing -alpha. I believe this changes the logic so that channel is always included in package name unless it's stable channel.