Skip to content

Conversation

@egieseke
Copy link
Contributor

Summary

Added support for building alpha channel for alphanet network.

Test Plan

Tested using go-algorand.muleci-full-pipeline.
Successful build here: https://jenkins.algodev.network/job/go-algorand.muleci-full-pipeline/357/

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #4132 (67d3560) into feature/alphanet (05061a3) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 67d3560 differs from pull request most recent head 3c43d95. Consider uploading reports for the commit 3c43d95 to get more accurate results

@@                 Coverage Diff                  @@
##           feature/alphanet    #4132      +/-   ##
====================================================
- Coverage             54.52%   54.52%   -0.01%     
====================================================
  Files                   391      391              
  Lines                 48701    48701              
====================================================
- Hits                  26555    26553       -2     
- Misses                19925    19927       +2     
  Partials               2221     2221              
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-2.17%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (ø)
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05061a3...3c43d95. Read the comment docs.

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks fine, but there's a lot here to track down we should document for Feature Net work.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me

Copy link
Contributor

@algolucky algolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment relating to the build-alphanet branch. https://github.com/algorand/go-algorand/pull/4132/files#r899155406

if the plan is to remove it in another PR or remove it now I'd approve. I'm just not sure what the plan is for that.

@egieseke
Copy link
Contributor Author

just one comment relating to the build-alphanet branch. https://github.com/algorand/go-algorand/pull/4132/files#r899155406

if the plan is to remove it in another PR or remove it now I'd approve. I'm just not sure what the plan is for that.

OK, good catch, removed that temporary switch.

@egieseke egieseke requested a review from algolucky June 29, 2022 20:44
@onetechnical onetechnical merged commit 476edf4 into algorand:feature/alphanet Jun 29, 2022
cce added a commit that referenced this pull request Aug 25, 2022
* add vAlpha1 consensus version
* increase maxMessageLength to be greater than MaxTxnBytesPerBlock
* set TxPoolSize 75K and 500ms ProposalAssemblyTime default
* increase VerifiedTranscationsCacheSize to match TxPoolSize
* Updated Alphanet topology to match betanet.
* Added alphanet genesis.json file.
* DevOps: Build Alphanet (#4132)
* define vAlpha2 consensus parameters
* If network is alphanet, then automatically adjust the DNS Bootstrap Id to "alphanet.algodev.network".
* Updated algonet recipe genesis files to use a alpha1 protocol.
* Updated algonet recipe genesis files to use a alpha2 protocol.
* Fixing rpm package name
* Distribute alphanet nodes to separate hosts.
* Changed machine type from m5d.4xl to d5d.4xl.
* Set genesis fee sync.
* Added c5d.4xlarge to host templates file.
* Updated recipe for algonet.
* Increated alphanet NPN nodes from 4 to 8.
* Increated alphanet NPN nodes from 8 to 10.
* Recipe for alphanet network extension.
* update VerifiedTranscationsCacheSize to 150k
* define consensus version vAlpha3 (#4305)
* Removed extra Relay nodes.
* set txBacklogSize to 26000
* add alpha3 and alpha4 consensus versions, same as v33 and v34
* set genesis.json back to vFuture for non-alphanet recipes
* set genesis.json to alpha4 for alphanet recipes
* extend TestConsensusUpgrades to ensure official version names
* TestConsensusUpgrades: additionally assert if final upgrade is a bad name

Co-authored-by: John Lee <john.lee@algorand.com>
Co-authored-by: egieseke <eric_gieseke@yahoo.com>
Co-authored-by: Jack Smith <jack.smith@algorand.com>
Co-authored-by: Jack <87339414+algojack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants