go-algorand 3.4.2-beta #3699
Merged
go-algorand 3.4.2-beta #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary We seem to have missed a few of these. We have a partitiontest linter, it seems that isn't working since we missed all of these. ## Test Plan Check the result of `_test_verification` to make sure this is all of the ones we missed.
## Summary Fix for a strange assert found by JJ ## Test Plan This is a test fix
We want to make PR Type labels required on PRs. This is a github action that will check for us if a correct label has been added" Tested on this PR. Feel free to test it here too by adding a label or removing it.
## Summary Make keys valid for 3million rounds. With the rework to part keys, our pipeline was running out of disk space ## Test Plan I used this to spin up a feature network
## Summary 1. `--full-config` options allows saving config file with all options, not only non-default. 2. Embed genesis.json for mainnet, testnet, betanet, devnet ## Test Plan Tested manually
## Summary This PR fixes a bug on algod's API. When a tree contains a missing child (not a full tree), the api handler omits this from the proof response and leads to a root mismatch ## Test Plan Add unit tests as well as convert the e2e to test this edge case.
## Summary Metrics counters where not cleared on close and lead to duplicate entries in metering report. ## Test Plan Added unit test. Tested manually. Closes algorand#3354
Limit PR Type and Category check to master branch
…r nodes. (algorand#3654) ## Summary Regen scenario 2 net.json file to include API endpoints for nodes. ## Test Plan Testing with scenario2 recipe with cicd perf pipeline.
Summary The TestPseudonodeFailedEnqueuedTasks test wasn't accounting correctly for errPseudonodeBacklogFull errors. Test Plan Run 1000 times localy. I was able to reproduce it consistently.
Nodes create the compact cert using falcon keys so the batch verification flag (related to the ed25519 scheme) is no longer necessary.
## Summary Update the sum hash library. ## Test Plan Use existing tests.
New algokey subcommand to generate transactions for bringing an account online or offline.
Usage:
```
~$ algokey part keyreg -h
Make key registration transaction
Usage:
algokey part keyreg [flags]
Flags:
--account string account address to bring offline, mutually exclusive with keyfile
--fee uint transaction fee (default 1000)
--firstvalid uint first round where the transaction may be committed to the ledger
-h, --help help for keyreg
--keyfile string participation keys to register, file is opened to fetch metadata for the transaction, mutually exclusive with account
--lastvalid uint last round where the generated transaction may be committed to the ledger, defaults to firstvalid + 1000
--network string the network where the provided keys will be registered, one of mainnet/testnet/betanet (default "mainnet")
--offline set to bring an account offline
-o, --outputFile string write signed transaction to this file, or '-' to write to stdout
```
onetechnical
requested review from
algobarb,
algojack,
bricerisingalgorand,
egieseke and
tsachiherman
egieseke
approved these changes
Feb 28, 2022
algojack
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Incorporate a fix for sumhash lib in upstream dependency.
Changelog
New Features
Enhancements
Bug Fixes
Protocol Upgrade
This release does not contain a protocol upgrade.
Additional Resources