Skip to content

CICD: Adding PR Type label checker #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsachiherman merged 23 commits into from
Feb 22, 2022
Merged

CICD: Adding PR Type label checker #3645

tsachiherman merged 23 commits into from
Feb 22, 2022

Conversation

@algojack
Copy link
Contributor

@algojack algojack commented Feb 17, 2022 •
edited
Loading

We want to make PR Type labels required on PRs. This is a github action that will check for us if a correct label has been added"

Tested on this PR. Feel free to test it here too by adding a label or removing it.

@algojack algojack self-assigned this Feb 17, 2022
@algojack algojack marked this pull request as ready for review February 17, 2022 14:02
algobarb
algobarb reviewed Feb 17, 2022
View reviewed changes
@algobarb
Copy link
Contributor

algobarb commented Feb 17, 2022

I'm good with this if we add the label and category to this PR per specs.

@yaovi-a
Copy link
Contributor

yaovi-a commented Feb 17, 2022

Same comment as Barbara. But would we just check that there's some text with a colon before the PR change?

@algojack algojack changed the title Adding PR Type label checker CICD: Adding PR Type label checker Feb 17, 2022
egieseke
egieseke reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@egieseke egieseke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it check for only one type label?
Can we add a regex to check the PR title?

@yaovi-a
Copy link
Contributor

yaovi-a commented Feb 17, 2022

Should it check for only one type label? Can we add a regex to check the PR title?

Yea, only one type of label. We should also make sure that there is one label attached and only one. If there's more than one that return "Failed: Found more than one label. Please include only one label."

@algojack
Copy link
Contributor Author

algojack commented Feb 17, 2022

added check to check that there's only one.

@algojack algojack changed the title CICD: Adding PR Type label checker Adding PR Type label checker Feb 17, 2022
@algojack algojack changed the title Adding PR Type label checker CICD: Adding PR Type label checker Feb 17, 2022
@algojack algojack changed the title CICD: Adding PR Type label checker Adding PR Type label checker Feb 17, 2022
@algojack algojack changed the title Adding PR Type label checker CICD: Adding PR Type label checker Feb 17, 2022
algobarb
algobarb approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman tsachiherman merged commit b4666bd into master Feb 22, 2022
@tsachiherman tsachiherman deleted the label-checker branch February 22, 2022 17:18
This was referenced Feb 28, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bricerisingalgorand bricerisingalgorand Awaiting requested review from bricerisingalgorand

@onetechnical onetechnical Awaiting requested review from onetechnical

3 more reviewers

@egieseke egieseke egieseke left review comments

@algobarb algobarb algobarb approved these changes

@yaovi-a yaovi-a yaovi-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@algojack algojack

Labels

New Feature Team Hyper Flow unplanned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@algojack @algobarb @yaovi-a @egieseke @tsachiherman