Skip to content

Conversation

@id-ms
Copy link
Contributor

@id-ms id-ms commented Feb 17, 2022

Summary

Nodes create the compact cert using falcon keys so the batch verification flag (related to the ed25519 scheme) is no longer necessary.

Test Plan

@id-ms id-ms changed the title remove batch verification flag from Compactcert struct remove batch verification flag from the compact certs struct Feb 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #3644 (e4093e8) into master (cbf1939) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3644   +/-   ##
=======================================
  Coverage   48.06%   48.07%           
=======================================
  Files         381      381           
  Lines       62080    62079    -1     
=======================================
+ Hits        29841    29842    +1     
+ Misses      28819    28817    -2     
  Partials     3420     3420           
Impacted Files Coverage Δ
ledger/internal/compactcert.go 77.77% <ø> (-0.31%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (-0.30%) ⬇️
ledger/internal/eval.go 71.87% <0.00%> (-0.29%) ⬇️
ledger/acctupdates.go 66.60% <0.00%> (+0.18%) ⬆️
network/wsPeer.go 68.33% <0.00%> (+0.27%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf1939...e4093e8. Read the comment docs.

@id-ms id-ms requested a review from tsachiherman February 17, 2022 11:57
@id-ms id-ms changed the title remove batch verification flag from the compact certs struct Algod: remove batch verification flag from the compact certs struct Feb 22, 2022
@id-ms id-ms self-assigned this Feb 22, 2022
@tsachiherman tsachiherman merged commit dac1fc1 into algorand:master Feb 25, 2022
@id-ms id-ms deleted the remove-batch-verification-from-cc branch October 25, 2022 16:26
tmc pushed a commit to tmc/go-algorand that referenced this pull request Mar 7, 2025
Nodes create the compact cert using falcon keys so the batch verification flag (related to the ed25519 scheme) is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants