Amoz pay docker support #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
reviewed
Oct 27, 2022
| @@ -0,0 +1,22 @@ | |||
| [[source]] | |||
src/aleph_client/__main__.py
Outdated
| @@ -373,6 +376,168 @@ def program( | |||
| asyncio.run(get_fallback_session().close()) | |||
|
|
|||
|
|
|||
|
|
|||
| # TODO: find an appropirate name | |||
src/aleph_client/__main__.py
Outdated
| def container( | ||
| image: str = typer.Argument(..., help="Path to an image archive exported with docker save."), | ||
| path: str = typer.Argument(..., metavar="SCRIPT", help="A small script to start your container with parameters"), | ||
| remote: bool = typer.Option(False, "--remote", "-r", help=" If --remote, IMAGE is a registry to pull the image from. e.g: library/alpine, library/ubuntu:latest"), |
There was a problem hiding this comment.
What about naming this --from-remote ?
src/aleph_client/__main__.py
Outdated
|
|
||
| # TODO: find an appropirate name | ||
| @app.command() | ||
| def container( |
There was a problem hiding this comment.
Using the namespace from #111 would be useful here. Not blocking.
src/aleph_client/__main__.py
Outdated
| # image = image_archive | ||
| # print(manifest) | ||
| echo("Preparing image for vm runtime") | ||
| docker_data_path = os.path.abspath("docker-data") |
There was a problem hiding this comment.
What is this docker-data directory ?
src/aleph_client/__main__.py
Outdated
| path = os.path.abspath(path) | ||
| entrypoint = path | ||
|
|
||
| # Create a zip archive from a directory |
There was a problem hiding this comment.
A first PR to move the code out of program() and remove duplication, then a second with the container specific code ?
src/aleph_client/docker/image.py
Outdated
| def __load_metadata(self, tar: TarFile, file: str) -> Dict[str, str]: | ||
| return json.load(tar.extractfile(file)) | ||
|
|
||
| def __init__(self, path: str): |
src/aleph_client/docker/image.py
Outdated
| self.diff_ids = self.config["rootfs"]["diff_ids"] | ||
| self.chain_ids = self.__compute_chain_ids() | ||
|
|
||
| def __compute_chain_ids(self) -> List[str]: |
There was a problem hiding this comment.
Why two underscores __ ? Why is this a method and not a separate function ?
See https://peps.python.org/pep-0008/#descriptive-naming-styles
src/aleph_client/docker/image.py
Outdated
|
|
||
| # I used recursion because it was simpler to execute, not because it's better | ||
| # cause it's not. TODO: use iteration | ||
| def recursive_compute_chain_id(index: int) -> str: |
There was a problem hiding this comment.
Recursion can be OK, but having functions not reachable from the outside because they only exist within another function makes them very difficult to test.
Solution: put all commands in a sub folder and use typer subcommands Use typer.Option and typer.Argument to document each command parameter
Solution: put all commands in a sub folder and use typer subcommands Use typer.Option and typer.Argument to document each command parameter
Solution: Pull image using API and reproduce docker data dir
…\nSolution: Use function rather than class method depending on self + use iteration rather than recursion
AmozPay
force-pushed
the
AmozPay-docker-support
branch
from
20b6265
to
9c547ab
Compare
Solution: Create a new subcommand, "aleph container create"
AmozPay
force-pushed
the
AmozPay-docker-support
branch
from
9c547ab
to
a7c81bf
Compare
Solution: Create two different output files in the output directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.