-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose between Pipfile and setup.cfg #76
Comments
I guess we should use |
@mrhouzlane can you manage this? |
Pipfile would be great for development and containerized usage, but we may have to support other library versions based on what is distributed with supported Linux distributions and homebrew. |
Pipefile is now working with python_version = "3.10" with all necessary packages but it is for development only. |
As I heard, setup.py does some stuff for us to upload the package to PyPI. Just to collect resources, here's some more info on packaging for PyPI: https://packaging.python.org/en/latest/tutorials/packaging-projects/ |
We use setup.cfg on all our projects. I have never used pipfile, but it seems to me like a classical case of "it ain't broke don't fix it". setup.cfg all the way for me. |
Packaging for Python has many options, including:
Pipfile and Poetry are great to manage dependencies, upgrade them, freeze them, etc. This is very useful when building web apps so everyone in the team uses the same version. They could be useful for pyaleph. However aleph-client is a library. We want users to be able to just Pipfile and Pipfile.lock were added to aleph-client before I started working on the project and are not actively used. I propose to remove them from this project. |
We do not use actively use the
Pipfile
andPipfile.lock
files at the moment, we usesetup.cfg
instead.We should have only one way to define dependencies, either
setup.cfg
orPipfile
.Originally posted by @hoh in #72 (comment)
The text was updated successfully, but these errors were encountered: