refacto: commands were cluttered + no cli help #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmozPay
force-pushed
the
AmozPay-typer-doc
branch
3 times, most recently
from
39bd4cf
to
c88639d
Compare
hoh
reviewed
Oct 6, 2022
|
|
||
| from aleph_client.cli_utils import ( | ||
| _setup_logging, | ||
| ) |
There was a problem hiding this comment.
Using parenthesis here seems useless and overkill.
| channel = "Aleph network channel where the message is located" | ||
| private_key = "Your private key. Cannot be used with --private-key-file" | ||
| private_key_file = "Path to your private key file" | ||
| ref = "Checkout https://aleph-im.gitbook.io/aleph-js/api-resources-reference/posts" |
There was a problem hiding this comment.
Constants are usually in UPPER_CASE in Python.
AmozPay
force-pushed
the
AmozPay-typer-doc
branch
2 times, most recently
from
2359b60
to
5127fa4
Compare
|
Command Command |
mrhouzlane
reviewed
Nov 15, 2022
Solution: put all commands in a sub folder and use typer subcommands Use typer.Option and typer.Argument to document each command parameter
AmozPay
force-pushed
the
AmozPay-typer-doc
branch
from
b0e7436
to
96347e2
Compare
|
Did a force push since I rebased the current branch on main. It adds the persistent programs option in |
httpx is required in tests when using fastapi.testclient
hoh
force-pushed
the
AmozPay-typer-doc
branch
from
9e91eb0
to
31cedef
Compare
|
The tests still fail due to an upgrade to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: put all commands in a sub folder and use typer subcommands
Use typer.Option and typer.Argument to document each command parameter