[WIP] Notebook - general-preprocessing-rainfall_noaa #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for the-environmental-ds-book canceled.
|
|
@NHomer-Edi @timo0thy can you double check if the version in the Netlify preview is the latest one of the round 1? Just add thumbs-up if the preview is ok. Then, I'll add some suggestions for a 2nd round in the notebook repository. |
|
Looks all good to me, thanks! |
|
👍 |
9 tasks
|
@timo0thy @NHomer-Edi I've finished the post-print stage (i.e. styling, adding badges, minor changes) of the notebook. May I ask to double check the Netlify preview and inspect if the Binder and links of the the notebook work for you. Note, the Rohub is incomplete, but I hope to have it ready before the release of the notebook Monday next week. |
|
@acocac The Netflify preview and Binder work well for me - no issues to report. |
timo0thy
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before review
Description
Add notebook in preprocessing NOAA timeseries for rainfall analysis at global scale and Borneo (see notebook idea in #53).
Motivation and Context
New notebook for the preprocessing theme.
How has this been tested?
GitHub actions deployed first in the forked templated by the main author, @timo0thy, then forked repo was transferred to the EnvDS book organisation (see https://github.com/Environmental-DS-Book/general-preprocessing-rainfall_noaa).
Types of changes
Checklist:
Additional information