Review - Round 1 #1
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@timo0thy @NHomer-Edi I've set this PR to get first reviews of the notebook. Note, I only added Nick's full name, his affiliation and GH handle and corrected the tag of the theme. @NHomer-Edi feel free to add your comments here or in the ReviewNB above. |
| @@ -8,11 +8,11 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
For accessibility purposes it is better to label links with descriptive text. So, rather than "obtained from this landing page" you could say "obtained from the NOAA Physical Sciences Laboratory", or similar.
Reply via ReviewNB
There was a problem hiding this comment.
Thanks and I've revised based on your suggestion, please check latest version on GitHub (review_round1 branch).
| @@ -8,11 +8,11 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Line #2. grid_area_weights = iris.analysis.cartography.area_weights(Borneo)
What is this line actually doing?
Maybe add one more comment to clarify what is happening here.
Reply via ReviewNB
There was a problem hiding this comment.
That's an interesting question involving some concepts of the Earth's shape/grid. Thanks to your suggestion I've added some extra description (in the text cell above but not as a code comment), as follows:
Note that due to the spherical nature of the planet Earth, the area of every grid-box is not the same, therefore we need to perform the weighted mean based on the weights by area.
Then hopefully the readers will be able to understand/follow the one-line comment above Line #2, and the remainder of the cell.
Based on comments from reviewers
Some new packages required for latest revision
|
@NHomer-Edi please can you confirm if you have any additional suggestion to Tim's replies. If not, I'll merge the PR and add some suggested changes in the visuals but in a second round. |
PR to review the first draft of the notebook
Corresponding authors: @timo0thy
Reviewers: @NHomer-Edi
Editor: @acocac