upgrade to Gradle 7.2 #7070
upgrade to Gradle 7.2 #7070
Conversation
|
Well this is going to be easy...
|
|
reverting the spotless upgrade since it actually breaks the format of some of the |
|
Everything is building!!! I would like to clean up the warnings though, they're super noisy. |
| @@ -15,16 +19,18 @@ import java.nio.file.Paths | |||
|
|
|||
| @CacheableTask | |||
| abstract class AirbyteDockerTask extends DefaultTask { | |||
| @Input | |||
| @Internal | |||
There was a problem hiding this comment.
This is used for the Docker hash tracking. Since this is a non-standard caching-related input, all subprojects that do airbyteDocker use this. If it's treated as an input we get a ton of implicit dependency warnings. Since it's actually an internal value not an input, we can change this here and remove the warnings. The value is still used for the up to date check so the behavior should be the same.
| @@ -97,6 +97,16 @@ jobs: | |||
| - name: Install Pyenv | |||
| run: python3 -m pip install virtualenv==16.7.9 --user | |||
|
|
|||
| - name: Set up CI Gradle Properties | |||
There was a problem hiding this comment.
these override the github gradle properties and increases use allocation for CI only
* upgrade to gradle 7.2 * get build working with gradle 7.2 * fix build * fix connector build? * EXCLUDE distTar and switch includes to excludes * switch back to includes * temporarily try to adjust properties * don't know why this was modified * revert spotless upgrade * upgrade gradle node (better arm support it says) * add back in Xss since we are getting StackOverflowError without it * revert bad spotless fmt * fix acceptance tests duplicates strategy * add zip for jdbc includes * check if this helps for java connectors * remove accidental commit * remove redundant * fix warning explosion * oops * override gradle.properties * remove set-env
closes #4006
@welly87 tracked down where we needed to handle
DuplicatesStrategyin #4006 (comment) ! Thank you @welly87 !todo: