Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Gradle 7.2 #7070

Merged
merged 22 commits into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix warning explosion
  • Loading branch information
jrhizor committed Oct 15, 2021
commit e8ab166b81ee28e88a358bb07288d24372a54f0b

This file was deleted.

5 changes: 2 additions & 3 deletions buildSrc/src/main/groovy/airbyte-docker.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import org.gradle.api.file.FileCollection
import org.gradle.api.tasks.CacheableTask
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.InputDirectory
import org.gradle.api.tasks.InputFile
import org.gradle.api.tasks.InputFiles
import org.gradle.api.tasks.Internal
import org.gradle.api.tasks.OutputFile
import org.gradle.api.tasks.PathSensitive
import org.gradle.api.tasks.PathSensitivity
Expand All @@ -19,8 +19,7 @@ import java.nio.file.Paths

@CacheableTask
abstract class AirbyteDockerTask extends DefaultTask {
@InputDirectory
@PathSensitive(PathSensitivity.RELATIVE)
@Internal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used for the Docker hash tracking. Since this is a non-standard caching-related input, all subprojects that do airbyteDocker use this. If it's treated as an input we get a ton of implicit dependency warnings. Since it's actually an internal value not an input, we can change this here and remove the warnings. The value is still used for the up to date check so the behavior should be the same.

abstract File rootDir

@InputFiles
Expand Down