upgrade to gradle 7.0 #2843
Closed
upgrade to gradle 7.0 #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tuliren
reviewed
Sep 8, 2021
| :init | ||
| @rem Get command-line arguments, handling Windows variants | ||
|
|
||
| if not "%OS%" == "Windows_NT" goto win9xME_args |
There was a problem hiding this comment.
Wow it has goto statement, and tries to support Windows ME! Who is still using that OS...
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this placeholder PR for changes necessary to upgrade. The first commit is the actual upgrade, but is failing because we're encountering some build deprecations.
Probably the easiest way to fix these is to fix them in our previous version based off of build scans:
DuplicatesStrategyfor the plugins we define inbuildSrc.┆Issue is synchronized with this Asana task by Unito