-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude tests using jdk.test.whitebox.WhiteBox class #4737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to temporarily exclude the other tests listed in eclipse-openj9/openj9#18037 (comment) using their corresponding OpenJ9 issues.
I see another PR, #4738, which addresses the above feedback. |
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llxia @LongyuZhang Requesting your review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MethodExitTest is being permanently disabled. See eclipse-openj9/openj9#17490 for more details on why MethodExitTest is being permanently disabled. MovingCompWindow and ToggleNotifyJvmtiTest were permanently disabled in adoptium#4737. But it didn't correctly point to adoptium#1297. It pointed to an OpenJ9 issue. This PR also corrects the link to adoptium#1297 for MovingCompWindow and ToggleNotifyJvmtiTest. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
MethodExitTest is being permanently disabled. See eclipse-openj9/openj9#17490 for more details on why MethodExitTest is being permanently disabled. MovingCompWindow and ToggleNotifyJvmtiTest were permanently disabled in adoptium#4737. But it didn't correctly point to adoptium#1297. It pointed to an OpenJ9 issue. This PR also corrects the link to adoptium#1297 for MovingCompWindow and ToggleNotifyJvmtiTest. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
MethodExitTest is being permanently disabled. See eclipse-openj9/openj9#17490 for more details on why MethodExitTest is being permanently disabled. MovingCompWindow and ToggleNotifyJvmtiTest were permanently disabled in #4737. But it didn't correctly point to #1297. It pointed to an OpenJ9 issue. This PR also corrects the link to #1297 for MovingCompWindow and ToggleNotifyJvmtiTest. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Closes: eclipse-openj9/openj9#18049