Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJDK test flag vm.continuations is false but should be true #18037

Closed
pshipton opened this issue Aug 29, 2023 · 5 comments
Closed

OpenJDK test flag vm.continuations is false but should be true #18037

pshipton opened this issue Aug 29, 2023 · 5 comments

Comments

@pshipton
Copy link
Member

https://github.com/ibmruntimes/openj9-openjdk-jdk21/blob/openj9/closed/test/jtreg-ext/requires/OpenJ9PropsExt.java#L44

If there are tests that fail when vm.continuations is set to true, we should exclude them and create issues to track.

@babsingh fyi

@pshipton pshipton added this to the Java 21 (0.42) milestone Aug 29, 2023
@pshipton pshipton changed the title The test flag vm.continuations is false but should be true OpenJDK test flag vm.continuations is false but should be true Aug 29, 2023
@fengxue-IS
Copy link
Contributor

Personal build in progress to verify the tests that require vm.continuations flag

@fengxue-IS
Copy link
Contributor

sanity.openjdk failures:

java/lang/Thread/virtual/CarrierThreadWaits.java
java/lang/Thread/virtual/GetStackTrace.java
jdk/internal/vm/Continuation/MovingCompWindow.java (OpenJDK specific, doesn't apply to OpenJ9)

extended.openjdk failures:

serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java
serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java
serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest.java (OpenJDK specific, doesn't apply to OpenJ9)

I will open Issue/PR on test failure and exclude this before enabling the vm.continuations flag.

@pshipton
Copy link
Member Author

Pls exclude the OpenJDK specific tests under a different issue, as we will mark it with the perm excluded label and close it.

@fengxue-IS
Copy link
Contributor

Created issues to track test failure:
#18051
#18052
#18053
#18054
Exclude PR adoptium/aqa-tests#4738

Perm exclude for OpenJDK specific testing under #18049 and exclude PR adoptium/aqa-tests#4737

@babsingh
Copy link
Contributor

babsingh commented Sep 1, 2023

Closing: OpenJDK test flag vm.continuations has been enabled; the failing tests have been excluded; and standalone issues have been opened for each failure.

@babsingh babsingh closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants