Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDK22] Permanently disbale RedefinePreviousVersions #4741

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

babsingh
Copy link
Contributor

RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:
- eclipse-openj9/openj9#18046
- eclipse-openj9/openj9#18038
- ibmruntimes/openj9-openjdk-jdk21#34
- adoptium#4736

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

@llxia @LongyuZhang Requesting your review. I didn't realize that there was a JDK22 exclude file until I looked at #4737 and #4738.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 7ef2b0f into adoptium:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants