Query git issue url to get issue status and add GIT_ISSUE_STATUS to the json #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @xius666. Could you provide the sample output in the comment? |
|
|
llxia
reviewed
Sep 18, 2021
disabledTestParser/issue_status.py
Outdated
| 'state': 'all'} | ||
| response = requests.get(query_url, params=params).json() | ||
| json_str = json.dumps(response) | ||
| return json.loads(json_str)["state"] |
There was a problem hiding this comment.
Could we add error handling here? i.e., what if the URL is invalid and we cannot get the state?
There was a problem hiding this comment.
I resolved it please review
llxia
reviewed
Sep 20, 2021
smlambert
approved these changes
Sep 28, 2021
xius666
added a commit
to xius666/aqa-tests
that referenced
this pull request
Sep 28, 2021
Mesbah-Alam
pushed a commit
that referenced
this pull request
Sep 28, 2021
* finish adding GIT_ISSUE_STATUS to the json * add error handling * delete output file * change the name of input file * change the common.xml * fix the then * change the to outputproperty in common.xm; * add the error msg * handle the case if branch not exit go to origin/branch * solve the nested echo problem * remove the change relaed to #2882 * move the if inside
LongyuZhang
pushed a commit
that referenced
this pull request
Oct 1, 2021
* finish adding GIT_ISSUE_STATUS to the json * add error handling * delete output file * change the name of input file * change the common.xml * fix the then * change the to outputproperty in common.xm; * add the error msg * handle the case if branch not exit go to origin/branch * solve the nested echo problem * remove the change relaed to #2882 * move the if inside * accept sha for openjdk_systemtest * accept sha for openj9-systemtest * get rid of repetetive code for cloneing stf * fix the outputproperty unable to overwrite * get rid of the change related to pr#2911 * change the git checkout logic * fix the property name * change the faikonerror to true
|
In future, let's start using the keyword fixes, closes or some allowable keyword (https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) so the issues get automatically closed once a PR is merged. Fixes #2701 |
smlambert
pushed a commit
that referenced
this pull request
Oct 12, 2021
* finish adding GIT_ISSUE_STATUS to the json * add error handling * delete output file * change the name of input file * change the common.xml * fix the then * change the to outputproperty in common.xm; * add the error msg * handle the case if branch not exit go to origin/branch * solve the nested echo problem * remove the change relaed to #2882 * move the if inside * accept sha for openjdk_systemtest * accept sha for openj9-systemtest * get rid of repetetive code for cloneing stf * fix the outputproperty unable to overwrite * revert the change * fixfix the outputproperty unable to overwrite for systemtest * fix formatting * change the logic for the openjdk system test * change logic for openj9-systemtest * fix no ending if * fix failonerror * fix the return * change the name of sha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issue #2701