Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:2698 Parse problem list and generate json file #2858

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

deepak-gittyup
Copy link
Contributor

Python script to parse exclude/ProblemList*.txt files and generate a unified ProblemList.json

Signed-off-by: deepak deepak.gittyup@gmail.com

Python script to parse exclude/ProblemList*.txt files and generate a unified ProblemList.json

Signed-off-by: deepak <deepak.gittyup@gmail.com>
@llxia
Copy link
Contributor

llxia commented Sep 16, 2021

Thanks @deepak-gittyup for working on this!

@llxia
Copy link
Contributor

llxia commented Sep 16, 2021

Could you also provide the output json file? Thanks

@deepak-gittyup
Copy link
Contributor Author

Could you also provide the output json file? Thanks

Added the output ProblemList.json in the latest commit

Hi, I also see 6 others commits appearing here
Looks like they were added between my first commit and my latest commit
Is this okay ?
Or should I close this one and send a new and clean PR ?

@llxia
Copy link
Contributor

llxia commented Sep 20, 2021

Python script to parse exclude/ProblemList*.txt files and generate a unified ProblemList.json

Signed-off-by: deepak <deepak.gittyup@gmail.com>
@deepak-gittyup
Copy link
Contributor Author

Thanks @deepak-gittyup for ProblemList.json. Sorry, my msg was not very clear. I meant to see the output in the comment. I do not think we need to deliver it in the repo atm.

I have removed ProblemList.json as a part fo the latest commit
Here is a sample output:

[
    {
        "TARGET": "jdk_custom",
        "CUSTOM_TARGET": "java/lang/Class/GetModuleTest.java",
        "GIT_ISSUE": "https://github.com/adoptium/aqa-tests/issues/1297",
        "PLATFORM": "all",
        "JDK_VERSION": "13",
        "JDK_IMPL": "openj9"
    },
    {
        "TARGET": "jdk_custom",
        "CUSTOM_TARGET": "java/lang/Class/GetPackageBootLoaderChildLayer.java",
        "GIT_ISSUE": "https://github.com/eclipse-openj9/openj9/issues/5274",
        "PLATFORM": "all",
        "JDK_VERSION": "13",
        "JDK_IMPL": "openj9"
    },
    {
        "TARGET": "jdk_custom",
        "CUSTOM_TARGET": "java/lang/Class/forName/NonJavaNames.sh",
        "GIT_ISSUE": "https://github.com/eclipse-openj9/openj9/issues/5225",
        "PLATFORM": "all",
        "JDK_VERSION": "13",
        "JDK_IMPL": "openj9"
    },
   .  .  . 
   .  .  . 
   .  .  . 
    {
        "TARGET": "jdk_custom",
        "CUSTOM_TARGET": "compiler/graalunit/UtilTest.java",
        "GIT_ISSUE": "https://github.com/adoptium/aqa-tests/issues/2804",
        "PLATFORM": "all",
        "JDK_VERSION": "11",
        "JDK_IMPL": "hotspot"
    },
    {
        "TARGET": "jdk_custom",
        "CUSTOM_TARGET": "javax/imageio/plugins/shared/ImageWriterCompressionTest.java",
        "GIT_ISSUE": "https://github.com/adoptium/aqa-tests/issues/2814",
        "PLATFORM": "ppc32_aix,ppc64_aix",
        "JDK_VERSION": "11",
        "JDK_IMPL": "hotspot"
    }
]

This PR should not contain other people's commits. We do not need to close this one and create a new one. If you fix your local branch, you can force push to your remote branch.

I am still slowly getting used to git
But, I did not know that I could overwrite the previous commit history by doing force push
Thanks for letting me know about this 👍

Are things looking okay now ?

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @deepak-gittyup !

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants