Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept sha for system test #2911

Merged
merged 33 commits into from
Oct 12, 2021
Merged

accept sha for system test #2911

merged 33 commits into from
Oct 12, 2021

Conversation

xius666
Copy link
Contributor

@xius666 xius666 commented Sep 28, 2021 •
edited
Loading

issue #2887

@xius666 xius666 marked this pull request as ready for review September 28, 2021 23:10
@xius666
Copy link
Contributor Author

xius666 commented Sep 28, 2021

grinder example:
adoptium:2556048c2904184172d44cf68e537d4e7c14c9df
eclipse-openj9:ac47f30f80d98114c35d6237e2a4681545629a16
Screen Shot 2021-09-28 at 5 13 01 PM

adoptium:master
eclipse-openj9:master
Screen Shot 2021-09-28 at 5 12 14 PM

adoptium:invalid
eclipse-openj9:invalid
Screen Shot 2021-09-28 at 4 59 17 PM

@llxia
Copy link
Contributor

llxia commented Sep 29, 2021

Thanks @xius666 . Could we separate the PR into two? One for the fix of STF and the other is for system tests?

@xius666
Copy link
Contributor Author

xius666 commented Sep 29, 2021 •
edited
Loading

the stf issue fix is in pr #2913 @llxia

@xius666 xius666 closed this Sep 30, 2021
@xius666 xius666 reopened this Sep 30, 2021
@xius666
Copy link
Contributor Author

xius666 commented Sep 30, 2021

I still need to update the code logic

@llxia
Copy link
Contributor

llxia commented Oct 4, 2021

Thanks @xius666 . Just for future reference, please provide Grinder links in the comments.

@llxia
Copy link
Contributor

llxia commented Oct 4, 2021

Grinder: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1558/

@xius666
Copy link
Contributor Author

xius666 commented Oct 4, 2021 •
edited
Loading

https://ci.adoptopenjdk.net/job/Grinder/1563/
https://ci.adoptopenjdk.net/job/Grinder/1565/

@llxia
Copy link
Contributor

llxia commented Oct 5, 2021

https://ci.adoptopenjdk.net/job/Grinder/1585/

llxia
llxia reviewed Oct 5, 2021
View reviewed changes
system/common.xml Outdated Show resolved Hide resolved
system/common.xml Outdated Show resolved Hide resolved
system/common.xml Outdated Show resolved Hide resolved
system/common.xml Outdated Show resolved Hide resolved
llxia
llxia approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xius666

@llxia
Copy link
Contributor

llxia commented Oct 8, 2021

@xius666 could you update your PR to remove the return character for aqa-systemtest and openj9-systemtest sha on zos? It should be similar to #2971.

Also, you may want to resolve the merge conflict first. Thank you!

@xius666
Copy link
Contributor Author

xius666 commented Oct 8, 2021 •
edited
Loading

fix pl review @llxia

llxia
llxia requested changes Oct 12, 2021
View reviewed changes
system/common.xml Outdated Show resolved Hide resolved
system/common.xml Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Oct 12, 2021

llxia
llxia approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xius666

smlambert
smlambert approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit b623536 into adoptium:master Oct 12, 2021
@smlambert smlambert mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xius666 @llxia @smlambert