-
Notifications
You must be signed in to change notification settings - Fork 201
feat(coachmark)!: migrate tokens #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4846c77
to
09761a2
Compare
🚀 Deployed on https://pr-1992--spectrum-css.netlify.app |
13 tasks
0ce6a34
to
099c9f2
Compare
a462d15
to
71e4d0c
Compare
607166c
to
34aa8f2
Compare
4399531
to
a98b090
Compare
a98b090
to
111401b
Compare
fe24ce5
to
e97c5e6
Compare
File metricsOverall Δ: +36.35 KB ⬆ (+0.99%) buttongroup-< 1KB ⬇
coachmark-4.54 KB ⬇
|
16 tasks
Closed in favor of #2323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates tokens and implements new styling for coach mark
CoachIndicator
andCoachMark
Jira Ticket - CSS 193
XD File
How and where has this been tested?
Browser(s) and OS(s) this was tested with:
Chrome Version 113.0.5672.63 on macOS
Safari 16.4 on macOS
Firefox 112.0.2 on macOS
Regression testing
Test Outline @jawinn
Validate: @jawinn
Screenshots
Desktop (medium)
Mobile (Large)
To-do list