-
Notifications
You must be signed in to change notification settings - Fork 201
feat(coachmark)!: migrate tokens #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
2933fa0
chore(coachmark): build changes
jenndiaz 05af23b
chore(coachmark): hard code tokens for indicators
jenndiaz e0057fa
chore(coachmark): hard code popover values
jenndiaz 43c5e35
chore(coachmark): implement tokens
jenndiaz 0d12c2d
feat(coachmark): use button group
jenndiaz 5cf5e5f
feat(coachmark): split indicator and popover
jenndiaz 5ce8bc2
feat(coachmark): stubs out variants
jenndiaz 546822f
chore(coachmark): remove popover from naming
jenndiaz 3d65c78
feat(coachmark): refactor to use popover
jenndiaz 2cb6919
feat(coachindicator): reduce motion
jenndiaz 4e03d3d
chore(coackmark): use new token values
jenndiaz 3f69857
feat(coachmark): mobile variant buttons
jenndiaz 1aa3ba3
chore(coachmark): use ava image
jenndiaz 65ab8dc
fix(coachmark): pagination on RTL
jenndiaz af3d216
chore(coachindicator): remove skin from template
jenndiaz 9bf6514
chore(coachindicator): clear change log
jenndiaz 763caee
fix(coachmark): add width to image
jenndiaz 5364fe0
feat(coachmark): wip update storybook
jenndiaz 2bcce73
chore(coachmark): display all variants
jenndiaz b66dd27
feat(coachmark): add icon only button to story
jenndiaz c13abc9
fix(coachmark): menu wrap
jenndiaz d6b4eb7
feat(coachmark): wip menu in storybook
jenndiaz 4362c48
chore(coachmark): add comments
jenndiaz 1946ec6
fix(coachmark): image fine tuning
jenndiaz c73a251
fix(coachmark): icon only button fixes
jenndiaz b658963
chore(coachmark): add mods
jenndiaz a108b36
chore(coachmark): hard code token values for compact
jenndiaz 930dca3
feat(coachmark): wip handle mobile variant
jenndiaz 91275b0
feat(coachmark): mobile toggle
jenndiaz 4659277
chore(coachmkar): use previous tokens
jenndiaz bbd3e81
chore(coachmark): hard code new token values
jenndiaz ca9af03
docs(coachmark): display variants
jenndiaz 8971e08
fix(coachmarkindicator): quiet variant animations
jenndiaz 55a87e3
feat(coachmarkindicator): add quiet to storybook
jenndiaz 8e0ab99
feat(coachmark): update stories
jenndiaz 449b00b
refactor(coachmark): use new tokens
jenndiaz fc5172e
fix(coachmark): display for action menu
jenndiaz 6b4caea
docs(coachmark): improve comments
jenndiaz 9a16fab
refactor(coachmark): small refactors
jenndiaz deb30e4
docs(coachindicator): correct documentation
jenndiaz 967d1d3
refactor(coachindicator): use better rootClass
jenndiaz 0f06268
refactor(coachmark): addresses PR feedback
jenndiaz 5aefc77
docs(coachmark): add migration notes
jenndiaz 92c56c1
feat(coachindicator): migrate
jenndiaz 3c7a1ae
refactor(coachindicator): remove mark
jenndiaz 0c924c1
refactor(coachindicator): quiet styling
jenndiaz ee2741e
chore(coachmark): update dependencies
jenndiaz d020301
refactor(coachindicator): rename in storybook
jenndiaz 6f6cdca
chore(coachindicator): remove unneeded code
jenndiaz 4c1d461
feat(coachindicator): display all colors
jenndiaz e9608ff
refactor(coachmark): large into custom tokens
jenndiaz 64dc2e5
feat(coachmark): enable action menu label
jenndiaz 0afe8d2
chore(coachmark,coachindicator): update deps & manual version for bet…
pfulton dac7c5a
fix(coachindicator): typo in custom property names
pfulton a505920
chore(coachindicator): manual version increase for alpha release
pfulton d43f974
refactor(coachindicator): use custom animation token
jenndiaz 935a2e5
chore(coachmark): update tokens package
jenndiaz d29d2bd
chore(coachmark): manual version update for beta release
pfulton 5fa19ae
chore(coachindicator): manual version update for alpha release
pfulton 5067344
fix(coachmark): correct button text
jenndiaz 4031c5f
chore(coachmark): remove physical property
jenndiaz 9d69bbe
chore(coachmark): corrects mod naming
jenndiaz dc39a54
chore(coachindicator): manual version bump for alpha release
pfulton e97c5e6
chore(coachmark): manual version update for beta release
pfulton a1232ea
chore(coachmark): re generate mods file
jenndiaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/dist/docs/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# Change Log | ||
|
||
All notable changes to this project will be documented in this file. | ||
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# @spectrum-css/coachindicator | ||
|
||
> The Spectrum CSS Coach Indicator component | ||
|
||
This package is part of the [Spectrum CSS project](https://github.com/adobe/spectrum-css). | ||
|
||
See the [Spectrum CSS documentation](https://opensource.adobe.com/spectrum-css/) and [Spectrum CSS on GitHub](https://github.com/adobe/spectrum-css) for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/*! | ||
Copyright 2023 Adobe. All rights reserved. | ||
This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. You may obtain a copy | ||
of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software distributed under | ||
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
OF ANY KIND, either express or implied. See the License for the specific language | ||
governing permissions and limitations under the License. | ||
*/ | ||
.spectrum-CoachIndicator{ | ||
--spectrum-coach-indicator-animation-keyframe-0-scale: 1; | ||
--spectrum-coach-indicator-animation-keyframe-0-opacity: 0; | ||
--spectrum-coach-indicator-animation-keyframe-50-scale: 1.5; | ||
--spectrum-coach-indicator-animation-keyframe-50-opacity: 1; | ||
--spectrum-coach-indicator-animation-keyframe-100-scale: 2; | ||
--spectrum-coach-indicator-animation-keyframe-100-opacity: 0; | ||
--spectrum-coach-indicator-quiet-animation-keyframe-0-scale: 0.8; | ||
} | ||
|
||
|
||
@keyframes pulse { | ||
0% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-animation-keyframe-0-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-0-opacity); | ||
} | ||
50% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-animation-keyframe-50-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-50-opacity); | ||
} | ||
100% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-animation-keyframe-100-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-100-opacity); | ||
} | ||
} | ||
|
||
@keyframes pulse--quiet { | ||
0% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-quiet-animation-keyframe-0-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-0-opacity); | ||
} | ||
50% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-animation-keyframe-50-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-50-opacity); | ||
} | ||
100% { | ||
-webkit-transform: scale(var(--spectrum-coach-indicator-animation-keyframe-100-scale)); | ||
opacity: var(--spectrum-coach-indicator-animation-keyframe-100-opacity); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = require("@spectrum-css/component-builder-simple"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
/*! | ||
Copyright 2023 Adobe. All rights reserved. | ||
This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. You may obtain a copy | ||
of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software distributed under | ||
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
OF ANY KIND, either express or implied. See the License for the specific language | ||
governing permissions and limitations under the License. | ||
*/ | ||
|
||
@import "animation.css"; | ||
|
||
.spectrum-CoachIndicator { | ||
--spectrum-coach-indicator-ring-border-size: var(--spectrum-border-width-200); | ||
--spectrum-coach-indicator-min-inline-size: calc(var(--spectrum-coach-indicator-ring-diameter) * 3); | ||
--spectrum-coach-indicator-min-block-size: calc(var(--spectrum-coach-indicator-ring-diameter) * 3); | ||
--spectrum-coach-indicator-ring-inline-size: var(--spectrum-coach-indicator-ring-diameter); | ||
--spectrum-coach-indicator-ring-block-size: var(--spectrum-coach-indicator-ring-diameter); | ||
|
||
--spectrum-coach-indicator-top: calc(var(--spectrum-coach-indicator-ring-diameter) * 0.75); | ||
--spectrum-coach-indicator-left: calc(var(--spectrum-coach-indicator-ring-diameter) * 0.75); | ||
|
||
/* animation */ | ||
--spectrum-coach-animation-indicator-ring-duration: var(--spectrum-animation-duration-6000); | ||
--spectrum-coach-animation-indicator-ring-inner-delay-multiple: -0.5; | ||
--spectrum-coach-animation-indicator-ring-center-delay-multiple: -0.66; | ||
--spectrum-coach-animation-indicator-ring-outer-delay-multiple: -1; | ||
--spectrum-coach-indicator-quiet-animation-ring-inner-delay-multiple: -0.33; | ||
--spectrum-coach-indicator-animation-name: pulse; | ||
--spectrum-coach-indicator-inner-animation-delay-multiple: var(--spectrum-coach-animation-indicator-ring-inner-delay-multiple); | ||
|
||
&--quiet { | ||
--mod-coach-indicator-min-inline-size: calc(var(--mod-coach-indicator-quiet-ring-diameter, var(--spectrum-coach-indicator-quiet-ring-diameter)) * 2.75); | ||
--mod-coach-indicator-min-block-size: calc(var(--mod-coach-indicator-quiet-ring-diameter, var(--spectrum-coach-indicator-quiet-ring-diameter)) * 2.75); | ||
--mod-coach-indicator-ring-inline-size: var(--mod-coach-indicator-quiet-ring-diameter, var(--spectrum-coach-indicator-quiet-ring-diameter)); | ||
--mod-coach-indicator-ring-block-size: var(--mod-coach-indicator-quiet-ring-diameter, var(--spectrum-coach-indicator-quiet-ring-diameter)); | ||
|
||
--mod-coach-indicator-top: calc(var(--spectrum-coach-indicator-quiet-ring-diameter) * 0.75); | ||
--mod-coach-indicator-left: calc(var(--spectrum-coach-indicator-quiet-ring-diameter) * 0.75); | ||
--mod-coach-indicator-animation-name: pulse--quiet; | ||
--mod-coach-indicator-inner-animation-delay-multiple: var(--mod-coach-indicator-quiet-animation-ring-inner-delay-multiple, var(--spectrum-coach-indicator-quiet-animation-ring-inner-delay-multiple)); | ||
} | ||
} | ||
|
||
.spectrum-CoachIndicator { | ||
position: relative; | ||
margin: var(--mod-coach-indicator-gap, var(--spectrum-coach-indicator-gap)); | ||
|
||
min-inline-size: var(--mod-coach-indicator-min-inline-size, var(--spectrum-coach-indicator-min-inline-size)); | ||
min-block-size: var(--mod-coach-indicator-min-block-size, var(--spectrum-coach-indicator-min-block-size)); | ||
} | ||
|
||
.spectrum-CoachIndicator-ring { | ||
display: block; | ||
position: absolute; | ||
|
||
border-style: solid; | ||
border-width: var(--mod-coach-indicator-ring-border-size, var(--spectrum-coach-indicator-ring-border-size)); | ||
border-radius: 50%; | ||
border-color: var(--mod-coach-indicator-ring-default-color, var(--spectrum-coach-indicator-ring-default-color)); | ||
|
||
inset-block-start: var(--mod-coach-indicator-top, var(--spectrum-coach-indicator-top)); | ||
inset-inline-start: var(--mod-coach-indicator-left, var(--spectrum-coach-indicator-left)); | ||
|
||
inline-size: var(--mod-coach-indicator-ring-inline-size, var(--spectrum-coach-indicator-ring-inline-size)); | ||
block-size: var(--mod-coach-indicator-ring-block-size, var(--spectrum-coach-indicator-ring-block-size)); | ||
animation: var(--mod-coach-indicator-animation-name, var(--spectrum-coach-indicator-animation-name)) var(--mod-coach-animation-indicator-ring-duration, var(--spectrum-coach-animation-indicator-ring-duration)) linear infinite; | ||
|
||
&:nth-child(1) { | ||
animation-delay: calc(var(--mod-coach-animation-indicator-ring-duration, var(--spectrum-coach-animation-indicator-ring-duration)) | ||
* var(--mod-coach-indicator-inner-animation-delay-multiple, var(--spectrum-coach-indicator-inner-animation-delay-multiple))); | ||
} | ||
|
||
&:nth-child(2) { | ||
animation-delay: calc( var(--mod-coach-animation-indicator-ring-duration, var(--spectrum-coach-animation-indicator-ring-duration)) | ||
* var(--mod-coach-animation-indicator-ring-center-delay-multiple, var(--spectrum-coach-animation-indicator-ring-center-delay-multiple))); | ||
} | ||
|
||
&:nth-child(3) { | ||
animation-delay: calc(var(--mod-coach-animation-indicator-ring-duration, var(--spectrum-coach-animation-indicator-ring-duration)) | ||
* var(--mod-coach-animation-indicator-ring-outer-delay-multiple, var(--spectrum-coach-animation-indicator-ring-outer-delay-multiple))); | ||
} | ||
} | ||
|
||
.spectrum-CoachIndicator--light .spectrum-CoachIndicator-ring { | ||
border-color: var(--mod-coach-indicator-ring-light-color, var(--spectrum-coach-indicator-ring-light-color)); | ||
} | ||
|
||
.spectrum-CoachIndicator--dark .spectrum-CoachIndicator-ring { | ||
border-color: var(--mod-coach-indicator-ring-dark-color, var(--spectrum-coach-indicator-ring-dark-color)); | ||
} | ||
|
||
@media (prefers-reduced-motion: reduce) { | ||
.spectrum-CoachIndicator-ring { | ||
animation: none; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: Coach indicator | ||
SpectrumSiteSlug: https://spectrum.adobe.com/page/coach-mark/ | ||
sections: | ||
- name: Migration Guide | ||
description: | | ||
- Coach Indicator is now a seperate component from Coach Mark | ||
examples: | ||
- id: coach-indicator | ||
name: Standard | ||
markup: | | ||
<div class="spectrum-CoachIndicator" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> | ||
|
||
<div class="spectrum-CoachIndicator spectrum-CoachIndicator--dark" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> | ||
|
||
<div class="spectrum-CoachIndicator spectrum-CoachIndicator--light" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> | ||
- id: coach-indicator-quiet | ||
name: Quiet | ||
markup: | | ||
<div class="spectrum-CoachIndicator spectrum-CoachIndicator--quiet" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> | ||
|
||
<div class="spectrum-CoachIndicator spectrum-CoachIndicator--dark spectrum-CoachIndicator--quiet" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> | ||
|
||
<div class="spectrum-CoachIndicator spectrum-CoachIndicator--light spectrum-CoachIndicator--quiet" style="display: inline-block;"> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
<div class="spectrum-CoachIndicator-ring"></div> | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
| Modifiable Custom Properties | | ||
| ----------------------------------------------------------------- | | ||
| `--mod-coach-animation-indicator-ring-center-delay-multiple` | | ||
| `--mod-coach-animation-indicator-ring-duration` | | ||
| `--mod-coach-animation-indicator-ring-outer-delay-multiple` | | ||
| `--mod-coach-indicator-animation-name` | | ||
| `--mod-coach-indicator-gap` | | ||
| `--mod-coach-indicator-inner-animation-delay-multiple` | | ||
| `--mod-coach-indicator-left` | | ||
| `--mod-coach-indicator-min-block-size` | | ||
| `--mod-coach-indicator-min-inline-size` | | ||
| `--mod-coach-indicator-quiet-animation-ring-inner-delay-multiple` | | ||
| `--mod-coach-indicator-quiet-ring-diameter` | | ||
| `--mod-coach-indicator-ring-block-size` | | ||
| `--mod-coach-indicator-ring-border-size` | | ||
| `--mod-coach-indicator-ring-dark-color` | | ||
| `--mod-coach-indicator-ring-default-color` | | ||
| `--mod-coach-indicator-ring-inline-size` | | ||
| `--mod-coach-indicator-ring-light-color` | | ||
| `--mod-coach-indicator-top` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
{ | ||
"name": "@spectrum-css/coachindicator", | ||
"version": "1.0.0-alpha.3", | ||
"description": "The Spectrum CSS Coach Indicator component ", | ||
"license": "Apache-2.0", | ||
"author": "Adobe", | ||
"homepage": "https://opensource.adobe.com/spectrum-css/coachindicator", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/adobe/spectrum-css.git", | ||
"directory": "components/coachindicator" | ||
}, | ||
"bugs": { | ||
"url": "https://github.com/adobe/spectrum-css/issues" | ||
}, | ||
"main": "dist/index-vars.css", | ||
"scripts": { | ||
"build": "gulp" | ||
}, | ||
"peerDependencies": { | ||
"@spectrum-css/tokens": ">=11" | ||
}, | ||
"devDependencies": { | ||
"@spectrum-css/component-builder-simple": "^2.0.17", | ||
"@spectrum-css/tokens": "^11.3.7", | ||
"gulp": "^4.0.0" | ||
}, | ||
"publishConfig": { | ||
"access": "public" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.