Skip to content

Commit 111401b

Browse files
committed
feat(coachmark): update stories
1 parent da46449 commit 111401b

File tree

3 files changed

+24
-33
lines changed

3 files changed

+24
-33
lines changed

components/actionmenu/stories/template.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export const Template = ({
1111
items = [],
1212
label,
1313
iconName,
14+
size = "m",
1415
isOpen = true,
1516
...globals
1617
}) => {
@@ -23,7 +24,7 @@ export const Template = ({
2324

2425
return [
2526
ActionButton({
26-
size: "m",
27+
size,
2728
label,
2829
iconName,
2930
isQuiet: false,

components/coachmark/stories/coachmark.stories.js

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// Import the component markup template
22
import { Template } from "./template";
33

4+
import { default as ActionButton } from "@spectrum-css/actionbutton/stories/actionbutton.stories.js";
5+
import { default as Menu } from "@spectrum-css/menu/stories/menu.stories.js";
6+
47
export default {
58
title: "Components/Coach mark",
69
description:
@@ -34,26 +37,19 @@ export default {
3437
},
3538
control: "boolean",
3639
},
37-
isMobile: {
38-
name: "Mobile Variant",
39-
type: { name: "boolean" },
40-
table: {
41-
type: { summary: "boolean" },
42-
category: "Component",
43-
},
44-
control: "boolean",
45-
},
4640
},
4741
args: {
4842
rootClass: "spectrum-CoachMark",
4943
hasActionMenu: true,
5044
hasPagination: true,
5145
hasImage: false,
52-
isMobile: false,
5346
},
5447
parameters: {
5548
actions: {
56-
handles: [],
49+
handles: [
50+
...ActionButton.parameters.actions.handles,
51+
...Menu.parameters.actions.handles,
52+
],
5753
},
5854
status: {
5955
type: process.env.MIGRATED_PACKAGES.includes("coachmark")
@@ -66,19 +62,7 @@ export default {
6662
export const Default = Template.bind({});
6763
Default.args = {};
6864

69-
export const DefaultWithImage = Template.bind({});
70-
DefaultWithImage.args = {
65+
export const WithMedia = Template.bind({});
66+
WithMedia.args = {
7167
hasImage: true,
7268
};
73-
74-
export const Mobile = Template.bind({});
75-
Mobile.args = {
76-
isMobile: true,
77-
};
78-
79-
export const MobileWithImage = Template.bind({});
80-
MobileWithImage.args = {
81-
isMobile: true,
82-
hasImage: true,
83-
};
84-

components/coachmark/stories/template.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { html } from "lit";
22
import { classMap } from "lit/directives/class-map.js";
3-
import { ifDefined } from 'lit/directives/if-defined.js';
3+
import { useArgs } from "@storybook/client-api";
44

55
import { Template as ButtonGroup } from "@spectrum-css/buttongroup/stories/template.js";
66
import { Template as ActionButton } from "@spectrum-css/actionbutton/stories/template.js";
@@ -18,14 +18,15 @@ export const Template = ({
1818
hasActionMenu = false,
1919
hasPagination,
2020
hasImage,
21-
isMobile,
21+
isOpen = true,
2222
...globals
2323
}) => {
24+
const [, updateArgs] = useArgs();
25+
2426
return html`
25-
<div cdiv
27+
<div
2628
class=${classMap({
2729
[rootClass]: true,
28-
[`${rootClass}--mobile`]: isMobile,
2930
...customClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
3031
})}
3132
>
@@ -44,7 +45,12 @@ export const Template = ({
4445
<div class="spectrum-CoachMark-title">Try playing with a pixel brush</div>
4546
<div class="spectrum-CoachMark-action-menu">
4647
${hasActionMenu ? ActionMenu({
47-
isOpen: false,
48+
onclick: function () {
49+
updateArgs({ isOpen: !isOpen });
50+
},
51+
isOpen,
52+
iconName: 'More',
53+
size: globals.scale === "large" ? "s" : "m",
4854
items: [
4955
{
5056
label: "Skip tour",
@@ -62,8 +68,8 @@ export const Template = ({
6268
<div class="${rootClass}-footer">
6369
${hasPagination ? html`<div class="spectrum-CoachMark-step"><bdo dir="ltr">2 of 8</bdo></div>` : ''}
6470
${ButtonGroup({
65-
size: isMobile ? 's' : 'm',
66-
items: isMobile ?
71+
size: globals.scale === "large" ? "s" : "m",
72+
items: globals.scale === "large" ?
6773
[
6874
{
6975
variant: "secondary",

0 commit comments

Comments
 (0)