Simplified fill slider with offset #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ RSP-629 - Fill Slider - with Offset
|
@devongovett the design and css is fine, but the performance while dragging is pretty terrible. Do we want to improve it on the css docs side first or do you want to fight with it on react-spectrum? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of #96. It adds a
spectrum-Slider-fillelement and uses absolute positioning to position it over the track using percentages computed in JavaScript rather than splitting up the track into more pieces.Related Issue
https://jira.corp.adobe.com/browse/RSP-629
How Has This Been Tested?
In spectrum-css docs, in react-spectrum storybook.
Screenshots (if appropriate):
Types of changes
Checklist: