Skip to content

docs: bring in main site content to dev site #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 16, 2020
Merged

docs: bring in main site content to dev site #646

merged 24 commits into from
Jun 16, 2020

Conversation

lazd
Copy link
Member

@lazd lazd commented Mar 16, 2020 •
edited
Loading

Description

This PR brings the dev site up to snuff with the content on the existing public site.

Screenshots

image

image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Fixup layout differences
  • Add Adobe footer
  • Find a way to run JS on FastLoad
  • [ ] See if there is a less disgusting way to do code samples in Get Started page
  • Design review by Spectrum Team
    • Give screenshot a min/max height on Get started page
    • Dark theme for syntax highlighted colors
  • This pull request is ready to merge.

lazd
lazd commented Mar 16, 2020
View reviewed changes
lazd
lazd commented Mar 16, 2020
View reviewed changes
lazd
lazd commented Mar 16, 2020
View reviewed changes
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/abf09f6-result-2020-03-16_18-07-03/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/abf09f6-result-2020-03-16_18-07-03/dist/docs/

@jianliao jianliao added the documentation Because documentation is important and shouldn't be broken label Mar 23, 2020
@lazd
Copy link
Member Author

lazd commented May 11, 2020

@GarthDB any insight on the easiest way to add the Adobe footer here?

@jianliao
Copy link
Contributor

@lazd Did you resolve the adobe footer issue? If not, I can help.

@lazd
Copy link
Member Author

lazd commented May 18, 2020

@jianliao I did not, go ahead and push commits directly to this branch! Thank you!

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/8b85bc6-result-2020-05-18_21-41-55/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/8b85bc6-result-2020-05-18_21-41-55/dist/docs/

@jianliao
Copy link
Contributor

jianliao commented May 18, 2020 •
edited
Loading

@lazd Please check latest dev site build to see the footer. There are some options to customize the footer. Let me know if there is anything you want to change.

theme:{
    backgroundColor:'#FFFFFF',
    columnTitleColor: '#00FF00',
    linkColor: '#4B4B4B',
    linkHoverColor: '#2C2C2C',
    separatorColor: '',
    caretColor: ''
}

But you have to deploy the site to *.adobe.com to see the change.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/ff70e63-result-2020-05-19_15-16-31/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/ff70e63-result-2020-05-19_15-16-31/dist/docs/

jianliao
jianliao reviewed May 19, 2020
View reviewed changes
@jianliao
Copy link
Contributor

@lazd I found that we need to move global footer out of the spectrum-Site-mainContainer as the footer script does not work well with fast-load. So I created a div with class spectrum-Site-footerContainer to wrapper the entire footer and move it out of the mainContainer. But I could not figure out how to make spectrum-Site-footerContainer display under the mainContainer. Please see my inline comment on components/site/index.css

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/ac7fd85-result-2020-05-19_19-08-39/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/ac7fd85-result-2020-05-19_19-08-39/dist/docs/

@lazd
Copy link
Member Author

lazd commented May 19, 2020

Hmm @jianliao seeing the footer appear on the right side of the screen on the latest devsite docs
image

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/c040fd4-result-2020-05-20_22-39-11/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/c040fd4-result-2020-05-20_22-39-11/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/d2af97e-result-2020-05-20_23-48-41/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/d2af97e-result-2020-05-20_23-48-41/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/9d377ae-result-2020-05-21_00-38-57/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/9d377ae-result-2020-05-21_00-38-57/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/27fa7a2-result-2020-06-08_18-50-36/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/27fa7a2-result-2020-06-08_18-50-36/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/6c05e53-result-2020-06-08_18-51-43/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/6c05e53-result-2020-06-08_18-51-43/dist/docs/

@lazd lazd marked this pull request as draft June 9, 2020 18:00
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/a0f8cdb-result-2020-06-10_14-14-09/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/a0f8cdb-result-2020-06-10_14-14-09/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/0ce40dd-result-2020-06-12_07-21-38/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/0ce40dd-result-2020-06-12_07-21-38/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/50460fb-result-2020-06-12_15-30-56/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/50460fb-result-2020-06-12_15-30-56/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/5890291-result-2020-06-15_19-42-56/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/5890291-result-2020-06-15_19-42-56/dist/docs/

@lazd
docs: execute JS in examples on FastLoad
c47bbb2 
* also, fix search reference
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/c60902f-result-2020-06-15_20-04-52/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/c60902f-result-2020-06-15_20-04-52/dist/docs/

@lazd
docs: re-use Prism dark link, remove it properly
bcedc18 
* was staying around when switching from dark -> darkest -> light
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/d2fc913-result-2020-06-15_21-32-34/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/d2fc913-result-2020-06-15_21-32-34/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/0e71394-result-2020-06-16_17-16-40/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/0e71394-result-2020-06-16_17-16-40/dist/docs/

@jianliao jianliao marked this pull request as ready for review June 16, 2020 17:50
@jianliao jianliao merged commit 12833ba into master Jun 16, 2020
@GarthDB GarthDB deleted the devsitemainsite branch June 16, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianliao jianliao jianliao approved these changes

Assignees

@lazd lazd

Labels
documentation Because documentation is important and shouldn't be broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazd @adobe-spectrum-bot @jianliao