Skip to content

✨RSP-629 - Fill Slider - with Offset #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

edify17
Copy link

@edify17 edify17 commented Feb 5, 2019

No description provided.

@GarthDB
Copy link
Member

GarthDB commented Feb 27, 2019

@NateBaldwinDesign do we want to include this? Was there any design review?
image

@GarthDB
Copy link
Member

GarthDB commented Feb 27, 2019

@sakshigupta what's the use case for it?

@NateBaldwinDesign
Copy link
Contributor

Yes, the offset typically occurs at the 50% mark, where the user can make adjustments to increase/decrease properties (such as in photography editing) starting from an origin point.

Likewise, there are scenarios where users may apply a preset and then make adjustments to the preset configurations. In that use-case, a product may want to have the fill originate from the position on the slider defined by the preset as a way of showing the user how much they've deviated from the preset they originally selected.

@GarthDB GarthDB requested a review from devongovett February 27, 2019 20:40
@GarthDB
Copy link
Member

GarthDB commented Feb 27, 2019

@devongovett are you ok with the js used here to implement the offset?

@GarthDB
Copy link
Member

GarthDB commented Feb 27, 2019

@NateBaldwinDesign thanks!

@devongovett
Copy link
Member

Doesn't seem to me like we need the JS in spectrum-css for it. Could just hard code the offsets in the doc examples.

@GarthDB
Copy link
Member

GarthDB commented Mar 7, 2019

@devongovett do you think this dom setup would work with how you would want to do the js in react?

@devongovett
Copy link
Member

made a simplified version in #116

@edify17
Copy link
Author

edify17 commented Mar 13, 2019

Closing it, as its no longer required

@edify17 edify17 closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants