-
Notifications
You must be signed in to change notification settings - Fork 201
✨RSP-629 - Fill Slider - with Offset #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NateBaldwinDesign do we want to include this? Was there any design review? |
@sakshigupta what's the use case for it? |
Yes, the offset typically occurs at the 50% mark, where the user can make adjustments to increase/decrease properties (such as in photography editing) starting from an origin point. Likewise, there are scenarios where users may apply a preset and then make adjustments to the preset configurations. In that use-case, a product may want to have the fill originate from the position on the slider defined by the preset as a way of showing the user how much they've deviated from the preset they originally selected. |
@devongovett are you ok with the js used here to implement the offset? |
@NateBaldwinDesign thanks! |
Doesn't seem to me like we need the JS in spectrum-css for it. Could just hard code the offsets in the doc examples. |
@devongovett do you think this dom setup would work with how you would want to do the js in react? |
made a simplified version in #116 |
Closing it, as its no longer required |
No description provided.