Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adobe/spectrum-css
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @spectrum-css/preview@4.1.11
Choose a base ref
...
head repository: adobe/spectrum-css
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @spectrum-css/preview@4.1.12
Choose a head ref
  • 16 commits
  • 201 files changed
  • 8 contributors

Commits on Aug 22, 2023

  1. chore: simplify gulp use by extracting dev & watch (#2099)

    * Update dependencies from beta tags to latest in actionbar and divider
    * Create a single gulpfile.js at root that handles building & spinning up the dev server for the current documentation site
    * Add an environment variable for the localhost URL to storybook for dev runs
    * Remove bundle-builder
    * Update build commands to use NX and run build in parallel across components (based on dependencies defined)
    * Remove docs building from component builders
    castastrophe authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    79748d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    7f99d1c View commit details
    Browse the repository at this point in the history
  2. revert: gulp and build updates (#2121)

    This reverts commit 79748d6. PR #2099.
    
    Refs: 79748d6
    castastrophe authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    03a37f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. fix(textfield): add line-height to prevent missing diacritics (#2123)

    This adds a line-height definition to the textfield's input and sets that value equal to the height of the input. This prevents diacritics from being cut off in certain languages.
    pfulton authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e44e4f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. fix(meter): update layout tokens (#2080)

    * chore(meter): updates tokens
    
    * chore(meter): wip add to storybook
    
    * chore(meter): wip as variant of progressbar
    
    * chore(meter): functioning storybook
    
    * feat(meter): add percent range to story controls
    
    * chore(meter): refactor to separate template
    
    * chore(meter): refactor to not use mods
    
    * chore(meter): address PR feedback
    
    * chore(meter): refactor fillColor in template
    
    * fix(meter): address  indentation error
    
    * chore(meter): mods
    jenndiaz authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    da88b3c View commit details
    Browse the repository at this point in the history
  2. fix(calendar): update css for disabled buttons (#2100)

    * fix(calendar): update css for disabled buttons
    
    * refactor(calendar): use [disabled]
    
    * refactor(calendar): add root not disabled
    
    * feat(calendar): match disabled tokens
    
    * refactor(calendar): organize custom variables
    
    * fix(icon): package version
    
    * feat(calendar): disabled colors match
    
    ---------
    
    Co-authored-by: Patrick Fulton <pfulton@adobe.com>
    jenndiaz and pfulton authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    868e150 View commit details
    Browse the repository at this point in the history
  3. feat(colorslider)!: spectrum tokens migration (#1924)

    BREAKING CHANGE: migrates Color Slider to use `@adobe/spectrum-tokens` and the new Opacity Checkerboard
    
    Additionally:
    * build(colorslider)!: migrate build to use core tokens
    Migrate dependencies and other build related files to use the new
    @spectrum-css/tokens package.
    
    * refactor(colorslider): convert CSS to use core tokens - wip
    
    - Add new tokens defined in design.
    - Use tokens in existing CSS.
    - Merge skin.css into index.css.
    
    * feat(colorslider): add story for 'alpha' gradient
    
    Add story that shows the existing variant from the docs, with a
    transparent color used in the gradient and checkerboard appearing behind
    it. Adds a hidden control to Storybook. This variant needed to be
    testable and compared against in Storybook.
    
    * refactor(colorslider): move styles out of hidden placeholder
    
    Removes unnecessary placeholder variable (%) that is only used once.
    Clarifies what these "hidden" styles are doing.
    
    * feat(colorslider): finalize css to use new core tokens
    
    - Finalize CSS to use new core tokens.
    - Integrates skin.css into index.css.
    - Remove "canvas" variant as was done with colorwheel component.
    - Replaces some properties with their logical properties.
    - Generate mods.
    
    * style(colorslider): prettier and stylelint on colorslider files
    
    Run prettier with automatic changes to colorslider files, to update
    formatting to match new changes to linting.
    
    And manually make a few changes after stylelint check.
    
    * fix(colorslider): highcontrast update
    
    Updates colors for high contrast to fix disabled border color being off.
    Refactors those colors and uses a local variable for the box-shadow
    color.
    
    Change: Uses CanvasText border color in high contrast mode, so
    component still shows a border in high contrast mode with a dark
    background theme. Border was previously barely visible.
    
    * refactor(colorslider): remove no longer needed colorhandle styles
    
    These styles for the nested ColorHandle appear to be no longer
    necessary.
    
    - hit area size (width and height) is available through colorhandle's
      --mod property. The global-dimension-size-300 was equal to the same
      pixel value already set by colorhandle using
      --spectrum-color-control-track-width
    
    - border-radius is set to 100% in colorhandle and there does not appear
      to be any option to support changing this through a mod or SWC options
    
    * fix(colorslider): remove added label and its spacing token
    
    Per discussion with design, the label on the design was meant to serve
    more as guidance, and does not need to be a part of the component.
    
    * feat(colorhandle): add --mod-colorhandle-hitarea-border-radius
    
    Add --mod custom property for the border radius of the hit area, so that
    other components that use colorhandle can easily customize it
    (colorslider sets it to square, not rounded).
    
    * fix(colorslider): keep square hit area on colorhandle with new mod
    
    Keep the square hit area (::after) on the nested colorhandle, which was
    defaulting to rounded, using the newly added passthrough for
    --mod-colorhandle-hitarea-border-radius
    
    * feat(colorslider): reversed gradient for rtl support and docs update
    
    Use same technique as SWC for reversing the gradient when using a RTL
    base direction. The handles were flipping to the other side using the
    new logical properties but the gradient was not.
    
    Also updates documentation around this and improves overall docs
    explanations. Changes first usage docs bullet point specifying
    translateX, as this does not appear to be correct (SWC changes the
    inset-inline-start and inset-block-end of the position absolute handle).
    
    Fixes capitalization of component name in a few places to match the
    sentence case specified in the Spectrum capitalization guidelines.
    
    * fix(colorslider): update stories and example colors
    
    Update gradient used and use the matching colorhandle background color
    for the new Alpha story.
    
    Add new story for the "With Image" example from the docs. This example
    also includes the 50% positioned handle, for testing/VRT purposes.
    
    * fix(colorslider): update mod name for checkerboard
    
    Custom property mod had the wrong name.
    
    Co-authored-by: Jennifer Grenier Diaz <jenn.diaz@heysparkbox.com>
    
    * style(colorslider): remove prettier auto formatting
    
    To ease merge and keep to existing style conventions. Changes were made
    before prettier auto formatting was reverted.
    
    * feat(colorslider): integrate opacitycheckerboard changes
    
    Integrate new opacitycheckerboard changes that have merged into main.
    ColorSlider now uses the opacitycheckerboard component, which is
    viewable with the Alpha variant.
    
    Also added a "Disabled" story to Storybook, so that's included in VRTs.
    
    * style(colorhandle): update indentation on addition
    
    Due to mix of tabs and spaces in file.
    
    * feat(opacitycheckerboard): modify stories for use in components
    
    - Modify storybook template so that it can be imported and used by other
      components' stories. Allow passing in content, and excluding the
      storybook testing wrapper markup.
    - Moves defaultValue to args, as that syntax has been deprecated in
      newer versions of Storybook:
      https://storybook.js.org/docs/react/api/arg-types#defaultvalue
    - Adds a new story with a centered background position mod, and
      clarifies that the arg is changing the mod.
    
    * feat(colorslider): use imported opacitycheckerboard story
    
    Use opacitycheckerboard story in the template for ColorSlider, so the
    checkerboard appears in the Alpha variant.
    
    * feat(colorslider): in storybook add focused class to color handle
    
    When isFocused is enabled in Storybook, also add the focused class to
    the colorhandle (showing it scaled up). Otherwise focused state in
    Storybook has no visual difference.
    
    * chore(colorslider): manual version increase for beta release
    
    * fix(colorslider): inset the box-shadow border
    
    The 'inset' of the box-shadow border had been lost from the skin.css, as
    noticed in VRTs.
    
    * chore(colorslider): manual version increase for beta release
    
    * build(colorslider): minimum colorhandle version
    
    Increase minimum version of colorhandle to be the latest release that
    includes the addition of --mod-colorhandle-hitarea-border-radius
    
    * build(colorslider): build with latest version of tokens
    
    Update devDependencies to use latest version of tokens package.
    
    * chore(colorslider): manual version increase for beta release
    
    ---------
    
    Co-authored-by: Jennifer Grenier Diaz <jenn.diaz@heysparkbox.com>
    Co-authored-by: Patrick Fulton <pfulton@adobe.com>
    3 people authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    da345bd View commit details
    Browse the repository at this point in the history
  4. chore(release): release

     - @spectrum-css/actionbar@6.0.64
     - @spectrum-css/calendar@4.0.8
     - @spectrum-css/colorslider@5.0.0
     - @spectrum-css/combobox@2.0.32
     - @spectrum-css/datepicker@1.0.45
     - @spectrum-css/fieldgroup@4.0.67
     - @spectrum-css/fieldlabel@7.0.28
     - @spectrum-css/pagination@6.0.41
     - @spectrum-css/progressbar@3.0.66
     - @spectrum-css/radio@8.0.4
     - @spectrum-css/search@6.0.16
     - @spectrum-css/searchwithin@5.0.9
     - @spectrum-css/slider@4.1.5
     - @spectrum-css/stepper@4.0.52
     - @spectrum-css/textfield@6.0.16
    pfulton committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4ca408d View commit details
    Browse the repository at this point in the history
  5. feat(taggroup)!: migrate to spectrum-tokens

    BREAKING CHANGE: migrates TagGroup to use `@adobe/spectrum-tokens`
    
    Update build related files to migrate to use of core tokens.
    
    Use new global tokens for margin, and simplify usage. Adds mod prefixed
    custom properties and improves docs with mod section and description
    text pulled from the tag guidelines.
    
    Updates example markup and migration guide.
    
    fix(taggroup): allow tag items to wrap to the next line
    
    Tag group flex items were not previously wrapping and would overflow and
    cut off at smaller screen sizes. This now follows the tag guidelines to
    wrap items to the next line. And adds a story that shows wrapping.
    
    CSS-500
    jawinn authored and pfulton committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    531e067 View commit details
    Browse the repository at this point in the history
  6. docs(tag): update examples and migration guide

    - Replace type 'reset' with type 'button'. Type 'reset' is only
      appropriate for resetting forms.
    - Migration guide: Include pluralized class renaming and clarify wording
      in section about icon size.
    - Rename 'removable' story to fix spelling.
    jawinn authored and pfulton committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cf81c7b View commit details
    Browse the repository at this point in the history
  7. chore(release): release

     - @spectrum-css/tag@8.0.2
     - @spectrum-css/taggroup@4.0.0
    pfulton committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    19b546e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. chore(deps-dev): bump the storybook-ecosystem group with 7 updates (#…

    …2124)
    
    Bumps the storybook-ecosystem group with 7 updates:
    
    | Package | From | To |
    | --- | --- | --- |
    | [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y) | `7.2.3` | `7.3.2` |
    | [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions) | `7.2.3` | `7.3.2` |
    | [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs) | `7.2.3` | `7.3.2` |
    | [@storybook/api](https://github.com/storybookjs/storybook/tree/HEAD/code/deprecated/manager-api-shim) | `7.2.3` | `7.3.2` |
    | [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/code/deprecated/client-api) | `7.2.3` | `7.3.2` |
    | [@storybook/web-components-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/web-components-webpack5) | `7.2.3` | `7.3.2` |
    | [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) | `7.2.3` | `7.3.2` |
    
    
    Updates `@storybook/addon-a11y` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/addons/a11y)
    
    Updates `@storybook/addon-actions` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/addons/actions)
    
    Updates `@storybook/addon-docs` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/addons/docs)
    
    Updates `@storybook/api` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/deprecated/manager-api-shim)
    
    Updates `@storybook/client-api` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/deprecated/client-api)
    
    Updates `@storybook/web-components-webpack5` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/frameworks/web-components-webpack5)
    
    Updates `storybook` from 7.2.3 to 7.3.2
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.3.2/code/lib/cli)
    
    ---
    updated-dependencies:
    - dependency-name: "@storybook/addon-a11y"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/addon-actions"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/addon-docs"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/api"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/client-api"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/web-components-webpack5"
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    - dependency-name: storybook
      dependency-type: direct:development
      update-type: version-update:semver-minor
      dependency-group: storybook-ecosystem
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f13f9d3 View commit details
    Browse the repository at this point in the history
  2. chore(deps-dev): bump @adobe/spectrum-tokens from 12.17.0 to 12.18.0 (#…

    …2125)
    
    Bumps [@adobe/spectrum-tokens](https://github.com/adobe/spectrum-tokens) from 12.17.0 to 12.18.0.
    - [Release notes](https://github.com/adobe/spectrum-tokens/releases)
    - [Commits](https://github.com/adobe/spectrum-tokens/compare/@adobe/spectrum-tokens@12.17.0...@adobe/spectrum-tokens@12.18.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@adobe/spectrum-tokens"
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    32f122a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. feat(underlay)!: migrate to use spectrum-tokens (#2096)

    BREAKING CHANGE: migrates Underlay to use `@adobe/spectrum-tokens`
    
    Additionally:
    * chore(underlay): build changes
    
    * chore(underlay): add mods
    
    * feat(underlay): add to storybook
    
    * feat(dialog): use underlay in story
    
    * refactor(dialog): story and template
    
    * refactor(underlay): use custom animation tokens
    
    * chore(underlay): mods
    
    * refactor(dialog): remove unneeded handle
    
    * fix(underlay): address pr feedback
    
    * refactor(underlay): use new token for underlay color
    
    * chore(underlay): manual version increase for beta release
    
    * chore(underlay): update mods
    
    * chore(underlay): remove skin import
    
    ---------
    
    Co-authored-by: Patrick Fulton <pfulton@adobe.com>
    jenndiaz and pfulton authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2e0651a View commit details
    Browse the repository at this point in the history
  2. refactor: remove is-focused and is-keyboardFocused (#2119)

    * refactor(assetcard): remove is-focused class
    * refactor(floatingactionbutton): remove is-focused class
    * refactor(infieldbutton): remove is-focused and is-keyboardFocused classes
    * refactor(logicbutton): remove is-focused class and references in storybook
    * refactor(steplist): remove is-focused class
    
    ---------
    
    Co-authored-by: Jennifer Grenier Diaz <jenn.diaz@heysparkbox.com>
    Co-authored-by: Patrick Fulton <pfulton@adobe.com>
    Co-authored-by: castastrophe <castastrophe@users.noreply.github.com>
    4 people authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6019dd6 View commit details
    Browse the repository at this point in the history
  3. chore(release): release

     - @spectrum-css/accordion@4.0.14
     - @spectrum-css/actionbar@6.0.65
     - @spectrum-css/actionbutton@5.0.4
     - @spectrum-css/actiongroup@4.0.4
     - @spectrum-css/actionmenu@4.0.55
     - @spectrum-css/alertbanner@1.1.22
     - @spectrum-css/alertdialog@1.0.2
     - @spectrum-css/assetcard@2.0.4
     - @spectrum-css/assetlist@3.0.77
     - @spectrum-css/avatar@6.0.49
     - @spectrum-css/badge@3.1.5
     - @spectrum-css/breadcrumb@8.0.4
     - @spectrum-css/button@11.0.4
     - @spectrum-css/buttongroup@6.1.2
     - @spectrum-css/calendar@4.0.9
     - @spectrum-css/card@6.0.14
     - @spectrum-css/checkbox@7.0.7
     - @spectrum-css/clearbutton@5.0.2
     - @spectrum-css/closebutton@4.0.4
     - @spectrum-css/coachmark@5.0.63
     - @spectrum-css/colorarea@4.0.38
     - @spectrum-css/colorhandle@7.0.4
     - @spectrum-css/colorloupe@4.1.15
     - @spectrum-css/colorslider@5.0.1
     - @spectrum-css/colorwheel@3.0.38
     - @spectrum-css/combobox@2.0.33
     - @spectrum-css/contextualhelp@2.0.31
     - @spectrum-css/cyclebutton@3.0.78
     - @spectrum-css/datepicker@1.0.46
     - @spectrum-css/dialog@8.0.0
     - @spectrum-css/divider@2.1.22
     - @spectrum-css/dropzone@5.0.18
     - @spectrum-css/fieldgroup@4.0.68
     - @spectrum-css/fieldlabel@7.0.29
     - @spectrum-css/floatingactionbutton@1.0.24
     - @spectrum-css/helptext@4.0.51
     - @spectrum-css/illustratedmessage@6.0.18
     - @spectrum-css/infieldbutton@3.0.8
     - @spectrum-css/inlinealert@7.0.42
     - @spectrum-css/link@4.0.62
     - @spectrum-css/logicbutton@2.0.1
     - @spectrum-css/menu@5.0.7
     - @spectrum-css/miller@3.0.77
     - @spectrum-css/pagination@6.0.42
     - @spectrum-css/picker@7.0.4
     - @spectrum-css/pickerbutton@4.0.8
     - @spectrum-css/popover@6.0.70
     - @spectrum-css/progressbar@3.0.67
     - @spectrum-css/progresscircle@2.0.62
     - @spectrum-css/quickaction@3.0.79
     - @spectrum-css/radio@8.0.5
     - @spectrum-css/rating@4.0.22
     - @spectrum-css/search@6.0.17
     - @spectrum-css/searchwithin@5.0.10
     - @spectrum-css/sidenav@4.0.6
     - @spectrum-css/slider@4.1.6
     - @spectrum-css/splitbutton@6.0.4
     - @spectrum-css/statuslight@6.0.49
     - @spectrum-css/steplist@3.0.75
     - @spectrum-css/stepper@4.0.53
     - @spectrum-css/swatch@5.0.9
     - @spectrum-css/swatchgroup@2.0.65
     - @spectrum-css/switch@4.0.4
     - @spectrum-css/table@4.0.71
     - @spectrum-css/tabs@4.0.13
     - @spectrum-css/tag@8.0.3
     - @spectrum-css/taggroup@4.0.1
     - @spectrum-css/textfield@6.0.17
     - @spectrum-css/thumbnail@5.0.4
     - @spectrum-css/toast@9.1.5
     - @spectrum-css/tokens@11.3.1
     - @spectrum-css/tooltip@5.1.8
     - @spectrum-css/tray@2.1.8
     - @spectrum-css/typography@5.0.37
     - @spectrum-css/underlay@3.0.0
     - @spectrum-css/preview@4.1.12
    pfulton committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e0fa7ea View commit details
    Browse the repository at this point in the history
Loading