docs: update usage documentation for invalid radio groups #2104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
🚀 Deployed on https://pr-2104--spectrum-css.netlify.app |
mlogsdon18
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
This looks great! Only thing I noticed was that we don't have an Icon component page so your icon.html link does not work, so may just need to remove that one or link out to https://spectrum.adobe.com/page/iconography/
jnjosh
force-pushed
the
jnjosh/invalid-radio-group-documentation
branch
from
bf80bdf to
b7acaa9
Compare
|
@mlogsdon18 Great catch! That's actually broken currently on the live site so I updated to remove the icon mention. The point here is that you should use Help Text in a Field group, so leaving it out makes sense in context. Open to thoughts on that. |
|
As these rules seem to no longer do anything, should they be removed? https://github.com/adobe/spectrum-css/blob/main/components/radio/index.css#L283-L289 |
jnjosh
force-pushed
the
jnjosh/invalid-radio-group-documentation
branch
2 times, most recently
from
b7acaa9 to
6fcd619
Compare
jnjosh
commented
Aug 22, 2023
jnjosh
force-pushed
the
jnjosh/invalid-radio-group-documentation
branch
from
6fcd619 to
a5139e8
Compare
jnjosh
changed the title
jnjosh
force-pushed
the
jnjosh/invalid-radio-group-documentation
branch
from
a5139e8 to
b3252ec
Compare
Rajdeepc
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to documentation improvement in SWC PR, adobe/spectrum-web-components#3558 related to issue adobe/spectrum-web-components#3005. This improves the documentation for the radio buttons in an invalid state and adds a usage instruction.
How and where has this been tested?
Documentation only.
Regression testing
n/a
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨