fix(calendar): update css for disabled buttons #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2100--spectrum-css.netlify.app |
jenndiaz
force-pushed
the
jenndiaz/css-564-fix-calendar-disabled-buttons
branch
from
b0d465d to
c0247c2
Compare
jenndiaz
force-pushed
the
jenndiaz/css-564-fix-calendar-disabled-buttons
branch
from
2219509 to
6767c60
Compare
jenndiaz
force-pushed
the
jenndiaz/css-564-fix-calendar-disabled-buttons
branch
from
7da9eff to
9aa691d
Compare
jenndiaz
requested review from
mlogsdon18,
Westbrook,
paulodetarsofm and
pfulton
BREAKING CHANGE: Alert variants of Dialog have been removed from Dialog and placed into their own new component, Alert Dialog Additionally: * feat(alertdialog): generate new component * feat(alertdialog): use new tokens * feat(alertdialog): adds all variants * feat(alertdialog): adds icons * feat(alertdialog): adds secondary button and scroll variants * chore(alertdialog): adds variant descriptions * fix(alertdialog): font family tokens * chore(alertdialog): refactor icon color * fix(alertdialog): icons on correct variants * feat(alertdialog): underlay color * feat(alertdialog): corner radius * fix(alertdialog): rtl for example button * fix(alertdialog): more rtl * feat(alertdialog): storybook variants * chore(alertdialog): update tokens * chore(alertdialog): remove alerts from dialog * fix(alertdialog): background color * fix(alerdialog): use max height token * fix(alertdialog): small bug fixes * chore(alertdialog): add mods * fix(alertdialog): aria and scrollable a11y * chore(alertdialog): css refactor * feat(alertdialog): work on story controls * chore(alertdialog): improve docs * fix(alertdialog): design feedback * chore(alertdialog): move scale specific styling to custom vars * chore(alertdialog): use custom props for nested components * feat(alertdialog): adds onClick to story btns * feat(alertdialog): adds underlay to story * chore(alertdialog): tokens version bump * fix(alertdialog): dialog max width * chore(alertdialog): adds legacy token fallback * fix(alertdialog): fallbacks for nested custom tokens * fix(alertdialog): default for justify content * chore(alertdialog): use % over vw * fix(alertdialog): change default for icon sizing pass throughs * fix(alertdialog): use initial * fix(alertdialog): remove pass throughs for icon * chore(alertdialog): remove space * chore(alertdialog): update yarn.lock file * chore(alertdialog): update yarn.lock * chore: update mods assets for dependencies * chore: aligning alpha releases * chore: bump alterdialog to reflect dep changes * chore(alertdialog): correct storybook location --------- Co-authored-by: Patrick Fulton <pfulton@adobe.com> Co-authored-by: castastrophe <castastrophe@users.noreply.github.com>
This reverts commit 92593c5.
pfulton
force-pushed
the
jenndiaz/css-564-fix-calendar-disabled-buttons
branch
from
9aa691d to
ba1bb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates calendar PrevMonth and NextMonth button icon colors
Jira Ticket
Discussed in slack with SWC
and confirmed design change with design
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Open the docs site for the calendar component
disabled-content-colorand match the disabled day textgray-700and match the day textRegression testing
Validate:
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨